Re: [PATCH] drm/amdkfd: fix shift out of bounds about gpu debug

2024-03-01 Thread Jay Cornwall
On 3/1/2024 00:35, Kim, Jonathan wrote: > The range check should probably flag any exception prefixed as > EC_QUEUE_PACKET_* as valid defined in kfd_dbg_trap_exception_code: > https://github.com/torvalds/linux/blob/master/include/uapi/linux/kfd_ioctl.h#L857 > + Jay to confirm this is the correct

RE: [PATCH] drm/amdkfd: fix shift out of bounds about gpu debug

2024-02-29 Thread Kim, Jonathan
[Public] > -Original Message- > From: Zhang, Jesse(Jie) > Sent: Friday, March 1, 2024 12:50 AM > To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Kuehling, Felix > ; Zhang, Yifan > Subject: RE: [PATCH] drm/amdkfd: fix shift out of b

RE: [PATCH] drm/amdkfd: fix shift out of bounds about gpu debug

2024-02-29 Thread Zhang, Jesse(Jie)
: fix shift out of bounds about gpu debug [Public] I think this was discussed in another thread. Exception codes should be range checked prior to applying the mask. Raising null events to the debugger or runtime isn't useful. I haven't gotten around to fixing this yet. I should have time

RE: [PATCH] drm/amdkfd: fix shift out of bounds about gpu debug

2024-02-29 Thread Kim, Jonathan
[Public] I think this was discussed in another thread. Exception codes should be range checked prior to applying the mask. Raising null events to the debugger or runtime isn't useful. I haven't gotten around to fixing this yet. I should have time this week. Just to double check, the out of boun