RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Huang, JinHuiEric > Sent: Wednesday, January 19, 2022 10:01 AM > To: Russell, Kent ; Kuehling, Felix > ; > amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arctur

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-19 Thread Eric Huang
*From:* amd-gfx on behalf of Felix Kuehling *Sent:* Tuesday, January 18, 2022 6:36 PM *To:* Huang, JinHuiEric ; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus Am 2022-01-18 um 5:45 p.m. schrieb Eric Huang: SDMA FW fixes the

RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-19 Thread Russell, Kent
[AMD Official Use Only] > -Original Message- > From: Kuehling, Felix > Sent: Tuesday, January 18, 2022 7:16 PM > To: Russell, Kent ; Huang, JinHuiEric > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus > &g

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Christian König
Am 18.01.22 um 21:13 schrieb Eric Huang: I understand Alex's concern. I think usually we only check the version when a feature is only available in a specific version, and other version or newer version doesn't have. In case of FW fix, we assume the driver and FWs have to be synchronous. If w

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Felix Kuehling
t; *O*+(1) 289-695-2122**| Ext 72122 > > > > *From:* amd-gfx on behalf of > Felix Kuehling > *Sent:* Tuesday, January 18, 2022 6:36 PM > *To:* Huang, JinHuiEric ; > amd-gfx@lists.freedesktop.org > *Subject:* Re: [PATCH] drm/amdkfd: enable heavy-weight T

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Russell, Kent
, JinHuiEric ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus Am 2022-01-18 um 5:45 p.m. schrieb Eric Huang: > SDMA FW fixes the hang issue for adding heavy-weight TLB > flush on Arcturus, so we can enable it. > > Signed-off-by

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Felix Kuehling
Am 2022-01-18 um 5:45 p.m. schrieb Eric Huang: > SDMA FW fixes the hang issue for adding heavy-weight TLB > flush on Arcturus, so we can enable it. > > Signed-off-by: Eric Huang Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 6 -- > drivers/gpu/drm

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Felix Kuehling
Am 2022-01-18 um 4:28 p.m. schrieb Eric Huang: > SDMA FW fixes the hang issue for adding heavy-weight TLB > flush on Arcturus, so we can enable it. > > Signed-off-by: Eric Huang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 9 ++--- > drivers/gpu/drm/amd/amdkfd/kfd_chardev.c

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Alex Deucher
On Tue, Jan 18, 2022 at 4:28 PM Eric Huang wrote: > > SDMA FW fixes the hang issue for adding heavy-weight TLB > flush on Arcturus, so we can enable it. > > Signed-off-by: Eric Huang Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 9 ++--- > drivers/gpu/d

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Dave Airlie
On Wed, 19 Jan 2022 at 06:14, Eric Huang wrote: > > I understand Alex's concern. I think usually we only check the version > when a feature is only available in a specific version, and other > version or newer version doesn't have. > > In case of FW fix, we assume the driver and FWs have to be syn

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Alex Deucher
gt;> -Original Message----- > >>> From: amd-gfx On Behalf Of Eric > >>> Huang > >>> Sent: Tuesday, January 18, 2022 2:09 PM > >>> To: Alex Deucher > >>> Cc: amd-gfx list > >>> Subject: Re: [PATCH] drm/amdkfd: enable h

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Eric Huang
Of Eric Huang Sent: Tuesday, January 18, 2022 2:09 PM To: Alex Deucher Cc: amd-gfx list Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus The SDMA fix is generic and not in a specific version of FW, so we don't have to check. Thanks, Eric On 2022-01-18 11:35, Alex

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Alex Deucher
the fix? Yes, that was my concern. Alex > > Kent > > > -Original Message- > > From: amd-gfx On Behalf Of Eric > > Huang > > Sent: Tuesday, January 18, 2022 2:09 PM > > To: Alex Deucher > > Cc: amd-gfx list > > Subject: Re: [PATCH]

RE: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Russell, Kent
c Huang > Sent: Tuesday, January 18, 2022 2:09 PM > To: Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus > > The SDMA fix is generic and not in a specific version of FW, so we don't > have to check. > >

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Eric Huang
The SDMA fix is generic and not in a specific version of FW, so we don't have to check. Thanks, Eric On 2022-01-18 11:35, Alex Deucher wrote: On Tue, Jan 18, 2022 at 11:16 AM Eric Huang wrote: SDMA FW fixes the hang issue for adding heavy-weight TLB flush on Arcturus, so we can enable it. D

Re: [PATCH] drm/amdkfd: enable heavy-weight TLB flush on Arcturus

2022-01-18 Thread Alex Deucher
On Tue, Jan 18, 2022 at 11:16 AM Eric Huang wrote: > > SDMA FW fixes the hang issue for adding heavy-weight TLB > flush on Arcturus, so we can enable it. Do we need to check for a specific fw version? Alex > > Signed-off-by: Eric Huang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c