Re: [PATCH] drm/amdgpu: use function pointer for gfxhub functions

2020-09-29 Thread Alex Deucher
On Thu, Sep 17, 2020 at 7:16 PM Oak Zeng wrote: > > gfxhub functions are now called from function pointers, > instead of from asic-specific functions. > > Signed-off-by: Oak Zeng Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 ++ > drivers/gpu/drm/am

RE: [PATCH] drm/amdgpu: use function pointer for gfxhub functions

2020-09-28 Thread Zeng, Oak
.z...@amd.com>> Cc: amd-gfx mailing list mailto:amd-gfx@lists.freedesktop.org>>; Deucher, Alexander mailto:alexander.deuc...@amd.com>>; Koenig, Christian mailto:christian.koe...@amd.com>> Subject: Re: [PATCH] drm/amdgpu: use function pointer for gfxhub functions Can so

RE: [PATCH] drm/amdgpu: use function pointer for gfxhub functions

2020-09-28 Thread Zeng, Oak
stian.koe...@amd.com> what do you think? Can you guys help to review this patch? Thanks Regards, Oak From: Ernst Sjöstrand Sent: Friday, September 18, 2020 5:03 AM To: Zeng, Oak Cc: amd-gfx mailing list ; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: use function

Re: [PATCH] drm/amdgpu: use function pointer for gfxhub functions

2020-09-18 Thread Ernst Sjöstrand
Can some of them be null and others not? Perhaps write that in the comments somewhere. Like v1 doesn't have get_fb_location for example. Regards //Ernst Den fre 18 sep. 2020 kl 01:16 skrev Oak Zeng : > gfxhub functions are now called from function pointers, > instead of from asic-specific functi