Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_gfx.c

2023-05-23 Thread Alex Deucher
On Tue, May 23, 2023 at 2:31 PM Srinivasan Shanmugam wrote: > > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c: In function ‘amdgpu_gfx_disable_kcq’: > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c:497:6: warning: variable ‘j’ set but > not used [-Wunused-but-set-variable] > 497 | int j; > | ^ >

Re: [PATCH] drm/amdgpu: remove unused variable num_xcc

2023-05-22 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 22, 2023 at 8:30 AM Tom Rix wrote: > > gcc with W=1 reports > drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c:2138:13: error: variable > ‘num_xcc’ set but not used [-Werror=unused-but-set-variable] > 2138 | int num_xcc; > | ^~~ > > This

RE: [PATCH] drm/amdgpu: remove unused variable

2023-03-01 Thread Chen, Guchun
Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: bobzhou Sent: Thursday, March 2, 2023 2:44 PM To: amd-gfx@lists.freedesktop.org; Chen, Guchun ; Cui, Flora ; Shi, Leslie ; Ma, Jun Cc: Zhou, Bob Subject: [PATCH] drm/amdgpu: remove unused variable building with gcc

Re: [PATCH] drm/amdgpu: remove unused variable ring

2023-02-24 Thread Alex Deucher
Applied. Thanks! Alex On Fri, Feb 24, 2023 at 11:45 AM Tom Rix wrote: > > building with gcc and W=1 reports > drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c:81:29: error: variable > ‘ring’ set but not used [-Werror=unused-but-set-variable] >81 | struct amdgpu_ring *ring; > |

Re: [PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread Christian König
Am 19.01.22 um 07:42 schrieb mziya: Remove set but unused variable. warning: variable 'umc_reg_offset' set but not used Signed-off-by: mziya You should use your full written name here. Apart from that nit the patch looks good to me. Christian. Reported-by: kernel test robot Reviewed-by:

RE: [PATCH] drm/amdgpu: remove unused variable

2022-01-18 Thread Zhang, Hawking
[AMD Official Use Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Ziya, Mohammad zafar Sent: Wednesday, January 19, 2022 14:23 To: Zhang, Hawking ; Lazar, Lijo ; Clements, John Cc: amd-gfx@lists.freedesktop.org; Ziya, Mohammad zafar ; kernel test robot Su

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

2021-02-26 Thread Christian König
Am 26.02.21 um 05:24 schrieb Kevin Wang: clean up unsued variable in amdgpu_dma_buf_unmap(). Fixes: drm/amdgpu: Remove amdgpu_device arg from free_sgt api Signed-off-by: Kevin Wang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 4 1 file changed, 4

RE: [PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unmap()

2021-02-25 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Kevin Wang Sent: Friday, February 26, 2021 12:25 To: amd-gfx@lists.freedesktop.org Cc: Wang, Kevin(Yang) Subject: [PATCH] drm/amdgpu: remove unused variable in amdgpu_dma_buf_unma

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Nirmoy
Thanks Updated and pushed to  brahma HEAD:refs/for/amd-staging-drm-next On 10/23/19 5:21 PM, Koenig, Christian wrote: > Maybe say parameter instead of variable in the subject. > > Am 23.10.19 um 16:35 schrieb Nirmoy Das: >> Signed-off-by: Nirmoy Das > Apart from that Acked-by: Christian König >

Re: [PATCH] drm/amdgpu: remove unused variable in amdgpu_gfx_kiq_free_ring

2019-10-23 Thread Koenig, Christian
Maybe say parameter instead of variable in the subject. Am 23.10.19 um 16:35 schrieb Nirmoy Das: > Signed-off-by: Nirmoy Das Apart from that Acked-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 +-- > drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.h | 3 +-- > drivers/gpu/d

Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover

2018-05-24 Thread Christian König
Reviewed-by: Christian König as well. Christian. Am 23.05.2018 um 19:11 schrieb Andrey Grodzovsky: Reviewed-by: Andrey Grodzovsky Andrey On 05/23/2018 01:08 PM, Harry Wentland wrote: It throws an unused variable warning. Signed-off-by: Harry Wentland ---   drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH] drm/amdgpu: Remove unused variable in amdgpu_device_gpu_recover

2018-05-23 Thread Andrey Grodzovsky
Reviewed-by: Andrey Grodzovsky Andrey On 05/23/2018 01:08 PM, Harry Wentland wrote: It throws an unused variable warning. Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_devi