Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Christian König
anuary 20, 2022 11:47 PM To: Kim, Jonathan ; Chen, Guchun ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag I think we could remove this warning as well, all we need to do is to make sure that the GART table is always restored from the m

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Chen, Guchun
Koenig, Christian Sent: Friday, January 21, 2022 3:24 PM To: Chen, Guchun ; Kim, Jonathan ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag Yeah, you of course still need to check if the table is allocated or not. Otherwise we will run immed

Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Christian König
Chen, Guchun ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag I think we could remove this warning as well, all we need to do is to make sure that the GART table is always restored from the metadata before it is enabled in hardware. I'

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Chen, Guchun
nuary 20, 2022 11:47 PM To: Kim, Jonathan ; Chen, Guchun ; Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag I think we could remove this warning as well, all we need to do is to make sure that the GART table is always restored from the metadat

Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Christian König
önig ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag I actually suggested to allocate the bounce buffer in VRAM, but that add a bit more latency. Christian. Am 20.01.22 um 15:00 schrieb Chen, Guchun: [Public] Hi Christian, Unfortunately,

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Chen, Guchun
; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: remove gart.ready flag [Public] Switching to a VRAM bounce buffer can drop performance around 4x~6x on Vega20 over larger access so it's not desired. Jon > -Original Message- > From: Koenig, Christian > Se

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Kim, Jonathan
Jonathan > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag > > I actually suggested to allocate the bounce buffer in VRAM, but that add a > bit more latency. > > Christian. > > Am 20.01.22 um 15:00 schrieb Chen, Guchun: > > [Publ

Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Christian König
M? Regards, Guchun -Original Message- From: Koenig, Christian Sent: Wednesday, January 19, 2022 10:38 PM To: Chen, Guchun ; Christian König ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag Hi Guchun, yes, just haven't found tim

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-20 Thread Chen, Guchun
m, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove gart.ready flag Hi Guchun, yes, just haven't found time to do this yet. Regards, Christian. Am 19.01.22 um 15:24 schrieb Chen, Guchun: > [Public] > > Hello Christian, > > Do you plan to subm

Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-19 Thread Christian König
ry 18, 2022 10:22 PM To: 'Christian König' ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: remove gart.ready flag [Public] Thanks for the clarification. The patch is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Christian König

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-19 Thread Chen, Guchun
[Public] Hello Christian, Do you plan to submit your code to drm-next branch? Regards, Guchun -Original Message- From: Chen, Guchun Sent: Tuesday, January 18, 2022 10:22 PM To: 'Christian König' ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdg

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-18 Thread Chen, Guchun
[Public] Thanks for the clarification. The patch is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Christian König Sent: Tuesday, January 18, 2022 10:10 PM To: Chen, Guchun ; Kim, Jonathan ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: remove

Re: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-18 Thread Christian König
Am 18.01.22 um 14:28 schrieb Chen, Guchun: [Public] - if (amdgpu_sriov_vf(adev) && amdgpu_in_reset(adev)) - goto skip_pin_bo; - - r = amdgpu_gtt_mgr_recover(&adev->mman.gtt_mgr); - if (r) - return r; - -skip_pin_bo: Does deleting skip_pin_bo path ca

RE: [PATCH] drm/amdgpu: remove gart.ready flag

2022-01-18 Thread Chen, Guchun
[Public] - if (amdgpu_sriov_vf(adev) && amdgpu_in_reset(adev)) - goto skip_pin_bo; - - r = amdgpu_gtt_mgr_recover(&adev->mman.gtt_mgr); - if (r) - return r; - -skip_pin_bo: Does deleting skip_pin_bo path cause bo redundant pin in SRIOV case? Regards,