ginal Message-
From: Christian König
Sent: 2019年11月29日 17:30
To: Tao, Yintian ; Koenig, Christian ;
Das, Nirmoy ; amd-gfx@lists.freedesktop.org
Cc: Tuikov, Luben
Subject: Re: [PATCH] drm/amdgpu: not remove sysfs if not create sysfs
Am 29.11.19 um 10:25 schrieb Tao, Yintian:
Hi Christian
Do you
4192.044099]
> drm_dev_register+0x12b/0x1c0 [drm]
>
>
> Best Regards
> Yintian Tao
> -Original Message-
> From: amd-gfx On Behalf Of
> Christian K?nig
> Sent: 2019年11月29日 16:52
> To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org
> Cc: Tuikov, Luben
> Subject: Re
日 16:52
To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org
Cc: Tuikov, Luben
Subject: Re: [PATCH] drm/amdgpu: not remove sysfs if not create sysfs
Well what we do here actually looks like complete overkill to me.
IIRC when the device is removed all subsequent sysfs directories are removed
automatical
0x5d/0x250 [amdgpu]
[ 4192.044099] drm_dev_register+0x12b/0x1c0 [drm]
Best Regards
Yintian Tao
-Original Message-
From: amd-gfx On Behalf Of Christian
K?nig
Sent: 2019年11月29日 16:52
To: Das, Nirmoy ; amd-gfx@lists.freedesktop.org
Cc: Tuikov, Luben
Subject: Re: [PATCH] drm/amdgpu: not re
Well what we do here actually looks like complete overkill to me.
IIRC when the device is removed all subsequent sysfs directories are
removed automatically as well.
So calling sysfs_remove_group() is superflous in the first place.
Regards,
Christian.
Am 29.11.19 um 09:34 schrieb Nirmoy:
Lub
Luben, This should take care of the warnings that you get when a navi fw
file is missing from initrd.
Regards,
Nirmoy
On 11/29/19 9:26 AM, Yintian Tao wrote:
When load amdgpu failed before create pm_sysfs and ucode_sysfs,
the pm_sysfs and ucode_sysfs should not be removed.
Otherwise, there w
Reviewed-by: Nirmoy Das
On 11/29/19 9:26 AM, Yintian Tao wrote:
When load amdgpu failed before create pm_sysfs and ucode_sysfs,
the pm_sysfs and ucode_sysfs should not be removed.
Otherwise, there will be warning call trace just like below.
[ 24.836386] [drm] VCE initialized successfully.
[
