Re: [PATCH] drm/amdgpu: Fix build error reported for some config

2021-07-28 Thread Lazar, Lijo
Reviewed-by: Lijo Lazar On 7/27/2021 11:58 AM, Pratik Vishwakarma wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c: In function ‘amdgpu_acpi_is_s0ix_active’: drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1045:32: error: ‘pm_suspend_target_state’ undeclared (first use in this function) 1045 |

Re: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Luben Tuikov
hun > > -Original Message- > From: Tuikov, Luben > Sent: Thursday, July 22, 2021 10:14 PM > To: Chen, Guchun ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Deucher, Alexander > > Subject: Re: [PATCH] drm/amdgpu: fix build error > > On 2021-07-22 5:25 a.m., G

RE: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Chen, Guchun
; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: fix build error On 2021-07-22 5:25 a.m., Guchun Chen wrote: > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c: In function > 'smu_cmn_send_msg_without_waiting': > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:259

Re: [PATCH] drm/amdgpu: fix build error

2021-07-22 Thread Luben Tuikov
On 2021-07-22 5:25 a.m., Guchun Chen wrote: > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c: In function > 'smu_cmn_send_msg_without_waiting': > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:259:15: error: 'struct > amdgpu_device' has no member named 'in_pci_err_recovery' >if (smu->adev

RE: [PATCH] drm/amdgpu: fix build error

2020-09-30 Thread Zhang, Hawking
[AMD Public Use] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Guchun Chen Sent: Wednesday, September 30, 2020 21:59 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; StDenis, Tom Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu: fix buil

Re: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD (V2)

2019-09-12 Thread Kuehling, Felix
On 2019-09-12 2:58 a.m., S, Shirish wrote: > On 9/12/2019 3:29 AM, Kuehling, Felix wrote: >> On 2019-09-11 2:52 a.m., S, Shirish wrote: >>> If CONFIG_HSA_AMD is not set, build fails: >>> >>> drivers/gpu/drm/amd/amdgpu/amdgpu_device.o: In function >>> `amdgpu_device_ip_early_init': >>> drivers/gpu/

Re: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD (V2)

2019-09-11 Thread S, Shirish
On 9/12/2019 3:29 AM, Kuehling, Felix wrote: > On 2019-09-11 2:52 a.m., S, Shirish wrote: >> If CONFIG_HSA_AMD is not set, build fails: >> >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.o: In function >> `amdgpu_device_ip_early_init': >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1626: undefined ref

Re: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD (V2)

2019-09-11 Thread Kuehling, Felix
On 2019-09-11 2:52 a.m., S, Shirish wrote: > If CONFIG_HSA_AMD is not set, build fails: > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.o: In function > `amdgpu_device_ip_early_init': > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1626: undefined reference to > `sched_policy' > > Use CONFIG_HSA_AMD to

RE: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD

2019-09-10 Thread S, Shirish
, Christian Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD This is pretty ugly. See a suggestion inline. On 2019-09-10 4:12 a.m., Huang, Ray wrote: >> -Original Message- >> From: S, Shirish >> Sent: Tuesday, Septe

Re: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD

2019-09-10 Thread Kuehling, Felix
This is pretty ugly. See a suggestion inline. On 2019-09-10 4:12 a.m., Huang, Ray wrote: >> -Original Message- >> From: S, Shirish >> Sent: Tuesday, September 10, 2019 3:54 PM >> To: Deucher, Alexander ; Koenig, Christian >> ; Huang, Ray >> Cc: amd-gfx@lists.freedesktop.org; S, Shirish

RE: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD

2019-09-10 Thread Huang, Ray
> -Original Message- > From: S, Shirish > Sent: Tuesday, September 10, 2019 3:54 PM > To: Deucher, Alexander ; Koenig, Christian > ; Huang, Ray > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PATCH] drm/amdgpu: fix build error without CONFIG_HSA_AMD > > If CONFIG_HSA_AMD is