RE: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc hw_fini

2023-04-24 Thread Zhang, Horatio
; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Xu, Feifei ; Yao, Longlong ; Zhang, Horatio Subject: RE: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc hw_fini [AMD Official Use Only - General] Let's handle umc and gfx ras cases in separated patch. gmc.ecc_irq maps

RE: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc hw_fini

2023-04-24 Thread Zhang, Horatio
Thanks, Horatio -Original Message- From: Christian König Sent: Monday, April 24, 2023 6:50 PM To: Zhang, Horatio ; amd-gfx@lists.freedesktop.org Cc: Yao, Longlong ; Xu, Feifei ; Chen, Guchun ; Zhang, Hawking Subject: Re: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc

RE: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc hw_fini

2023-04-24 Thread Zhang, Hawking
[AMD Official Use Only - General] Let's handle umc and gfx ras cases in separated patch. gmc.ecc_irq maps to df mca interrupt, which is enabled by firmware per IFWI setting. Check GFX RAS mask is not correct in such case. host driver is not privileged to enable/disable the interrupt. As you not

Re: [PATCH] drm/amdgpu: fix amdgpu_irq_enabled warning in gfx and gmc hw_fini

2023-04-24 Thread Christian König
Am 24.04.23 um 12:37 schrieb Horatio Zhang: The call trace occurred when the amdgpu is suspended before the mode1 reset. For the IP block that do not support ras features, the relevant interrupt is not opened during initialization, but hw_fini forced the close of this interrupt, which resulted in