Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v2

2018-11-20 Thread Christian König
Am 19.11.18 um 21:08 schrieb Kuehling, Felix: Hi Christian, On 2018-11-19 6:24 a.m., Christian König wrote: Am 15.11.18 um 20:10 schrieb Yang, Philip: paging queues doorbell index use existing assignment sDMA_HI_PRI_ENGINE0/1 index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 dwor

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v2

2018-11-19 Thread Kuehling, Felix
Hi Christian, On 2018-11-19 6:24 a.m., Christian König wrote: > Am 15.11.18 um 20:10 schrieb Yang, Philip: >> paging queues doorbell index use existing assignment >> sDMA_HI_PRI_ENGINE0/1 >> index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 >> dwords to >> enable the new doorbell ind

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v2

2018-11-19 Thread Christian König
Am 15.11.18 um 20:10 schrieb Yang, Philip: paging queues doorbell index use existing assignment sDMA_HI_PRI_ENGINE0/1 index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 dwords to enable the new doorbell index. v2: disable paging queue doorbell on Vega10 and Vega12 with SRIOV Change

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Kuehling, Felix
On 2018-11-16 4:35 p.m., Alex Deucher wrote: >> + ring->doorbell_index += 0x400; > I don't quite understand how this works. Why don't we have to adjust > the doorbell range registers in the nbio code? NBIO only looks at the lower 12 bits of the doorbell address. So adding 0

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Yang, Philip
On 2018-11-16 4:35 p.m., Alex Deucher wrote: > On Fri, Nov 16, 2018 at 2:08 PM Yang, Philip wrote: >> Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging >> queue will >> break SRIOV, instead we can reserve and map two doorbell pages for amdgpu, >> paging >> queues doorbell

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Alex Deucher
On Fri, Nov 16, 2018 at 2:08 PM Yang, Philip wrote: > > Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for paging > queue will > break SRIOV, instead we can reserve and map two doorbell pages for amdgpu, > paging > queues doorbell index use same index as SDMA gfx queues index but

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support v3

2018-11-16 Thread Kuehling, Felix
Looks good to me. Reviewed-by: Felix Kuehling I hope Alex or Christian can also review this in case I'm missing something about how doorbells are used in amdgpu. Regards,   Felix On 2018-11-16 2:08 p.m., Yang, Philip wrote: > Because increase SDMA_DOORBELL_RANGE to add new SDMA doorbell for pag

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support

2018-11-15 Thread Yang, Philip
t;Felix > > -Original Message- > From: amd-gfx On Behalf Of Yang, > Philip > Sent: Thursday, November 15, 2018 12:54 PM > To: Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amdgpu: enable paging queue doorbell support > > On 2018-11-15 11:43

RE: [PATCH] drm/amdgpu: enable paging queue doorbell support

2018-11-15 Thread Kuehling, Felix
drm/amdgpu: enable paging queue doorbell support On 2018-11-15 11:43 a.m., Alex Deucher wrote: > On Thu, Nov 15, 2018 at 11:08 AM Yang, Philip wrote: >> paging queues doorbell index use existing assignment >> sDMA_HI_PRI_ENGINE0/1 index, and increase SDMA_DOORBELL_RANGE size >&g

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support

2018-11-15 Thread Yang, Philip
On 2018-11-15 11:43 a.m., Alex Deucher wrote: > On Thu, Nov 15, 2018 at 11:08 AM Yang, Philip wrote: >> paging queues doorbell index use existing assignment sDMA_HI_PRI_ENGINE0/1 >> index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 dwords to >> enable the new doorbell index. >> >> Ch

Re: [PATCH] drm/amdgpu: enable paging queue doorbell support

2018-11-15 Thread Alex Deucher
On Thu, Nov 15, 2018 at 11:08 AM Yang, Philip wrote: > > paging queues doorbell index use existing assignment sDMA_HI_PRI_ENGINE0/1 > index, and increase SDMA_DOORBELL_RANGE size from 2 dwords to 4 dwords to > enable the new doorbell index. > > Change-Id: I9adb965f16ee4089d261d9a22231337739184e49