RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-17 Thread Zeng, Oak
:50 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Quan, Evan Subject: RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons + Felix -Original Message- From: Kim, Jonathan Sent: Wednesday, October 16, 2019 8:49 PM To: amd-gfx@lists.freedesktop.org Cc: felix.keuhl

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-17 Thread Kim, Jonathan
/amdgpu: disable c-states on xgmi perfmons I got compiler warnings after update this morning, because the variables are not initialized in df_v3_6_set_df_cstate() return failed path. CC [M] drivers/gpu/drm/amd/amdgpu/gmc_v9_0.o CC [M] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.o /home/yangp/git

Re: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-17 Thread Yang, Philip
I got compiler warnings after update this morning, because the variables are not initialized in df_v3_6_set_df_cstate() return failed path. CC [M] drivers/gpu/drm/amd/amdgpu/gmc_v9_0.o CC [M] drivers/gpu/drm/amd/amdgpu/gfxhub_v1_1.o /home/yangp/git/compute_staging/kernel/drivers/gpu/drm/am

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Quan, Evan
Reviewed-by: Evan Quan > -Original Message- > From: Kim, Jonathan > Sent: 2019年10月17日 10:06 > To: amd-gfx@lists.freedesktop.org > Cc: Kuehling, Felix ; Quan, Evan > ; Kim, Jonathan ; Kim, > Jonathan > Subject: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons > > read or writes to

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
Thanks Evan. Resent with fixes. -Original Message- From: Quan, Evan Sent: Wednesday, October 16, 2019 9:34 PM To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix Subject: RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons Hi Jonathan, At default, vega20

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Quan, Evan
esktop.org > Cc: Kuehling, Felix ; Quan, Evan > > Subject: RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons > > + Felix > > -Original Message- > From: Kim, Jonathan > Sent: Wednesday, October 16, 2019 8:49 PM > To: amd-gfx@lists.freedesktop.org > Cc: fel

RE: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons

2019-10-16 Thread Kim, Jonathan
+ Felix -Original Message- From: Kim, Jonathan Sent: Wednesday, October 16, 2019 8:49 PM To: amd-gfx@lists.freedesktop.org Cc: felix.keuhl...@amd.com; Quan, Evan ; Kim, Jonathan ; Kim, Jonathan Subject: [PATCH] drm/amdgpu: disable c-states on xgmi perfmons read or writes to df registe