RE: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-27 Thread Yu, Lang
4:27 AM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Huang, Ray Subject: Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers [Public] Should we set *flags = 0 before we return? Alex From: Yu, Lang mailto:lang...@amd.com

Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-26 Thread Deucher, Alexander
[Public] Should we set *flags = 0 before we return? Alex From: Yu, Lang Sent: Wednesday, January 26, 2022 2:53 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Lazar, Lijo ; Huang, Ray ; Yu, Lang Subject: [PATCH] drm/amdgpu: add safeguards for ac

RE: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-26 Thread Yu, Lang
causes the issue. Regards, Lang From: Lazar, Lijo Sent: Wednesday, January 26, 2022 8:06 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Yu, Lang Subject: Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers [Public] Hi Lang, There

Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-26 Thread Lazar, Lijo
[Public] Hi Lang, There are ASICs in which driver doesn't enable CG, and then these flags will be false. However, the CG will be enabled by another component like VBIOS. Driver still reports the CG status eventhough driver doesn't enable it. For those, this logic doesn't work. BTW, could you

Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-26 Thread Christian König
Am 26.01.22 um 12:02 schrieb Lang Yu: On 01/26/ , Christian König wrote: Am 26.01.22 um 08:53 schrieb Lang Yu: We observed a gpu hang when querying mmhub CG status(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan skillfish doesn't support any CG features. Only allow asics which sup

Re: [PATCH] drm/amdgpu: add safeguards for accessing mmhub CG registers

2022-01-26 Thread Christian König
Am 26.01.22 um 08:53 schrieb Lang Yu: We observed a gpu hang when querying mmhub CG status(i.e., cat amdgpu_pm_info) on cyan skillfish. Acctually, cyan skillfish doesn't support any CG features. Only allow asics which support CG features accessing related registers. Will add similar safeguards f