Re: [PATCH] drm/amdgpu: add DP audio support for si dce6

2017-02-21 Thread Alex Deucher
On Tue, Feb 21, 2017 at 10:21 AM, Deucher, Alexander wrote: >> -Original Message- >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >> Of Xiaojie Yuan >> Sent: Monday, February 20, 2017 5:16 AM >> To: amd-gfx@lists.freedesktop.org >> Cc: Yuan, Xiaojie >> Subject: [P

RE: [PATCH] drm/amdgpu: add DP audio support for si dce6

2017-02-21 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Xiaojie Yuan > Sent: Monday, February 20, 2017 5:16 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yuan, Xiaojie > Subject: [PATCH] drm/amdgpu: add DP audio support for si dce6 > > Signed-off-b

RE: [PATCH] drm/amdgpu: add DP audio support for si dce6

2017-02-20 Thread Zhang, Jerry
Hi Xiaojie, It looks nice basically. So Acked-by: Junwei Zhang Just some reg programing style advice for better view. > + tmp = REG_SET_FIELD(0, AZALIA_F0_CODEC_ENDPOINT_INDEX, > + AZALIA_ENDPOINT_REG_INDEX, reg); > + tmp = REG_SET_FIELD(tmp, AZALIA_F0_CODEC_ENDPOINT