ng
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, November 15, 2019 6:14 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for
tdr
Attached.
Emily - can you give it a try ?
Andrey
On 11/14
tian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Attached.
Emily - can you give it a try ?
Andrey
On 11/14/19 3:12 AM, Christian König wrote:
What about instead of peeking at the job to actually remove it
from
ring_mirro
--Original Message-
From: Grodzovsky, Andrey
Sent: Friday, November 15, 2019 6:14 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Attached.
Emily - can you give it a try ?
Andrey
On 11/14/19 3:12 AM, Chris
am busying with another issue, maybe will try
next week.
Best wishes
Emily Deng
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, November 15, 2019 6:14 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointe
ek.
Best wishes
Emily Deng
-Original Message-
From: Grodzovsky, Andrey
Sent: Friday, November 15, 2019 6:14 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Attached.
Emily - can you give it a try
ian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Attached.
Emily - can you give it a try ?
Andrey
On 11/14/19 3:12 AM, Christian König wrote:
What about instead of peeking at the job to actually remove it from
ring_mirror_list r
:14 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Attached.
Emily - can you give it a try ?
Andrey
On 11/14/19 3:12 AM, Christian König wrote:
What about instead of peeking at the job to actually remove
>>>> [11381.225486] Emily:drm_sched_cleanup_jobs:begin,tid:2262,
>>>>>>>>> pid:2262
>>>>>>>>> Nov 12 12:58:20 ubuntu-drop-August-2018-rc2-gpu0-vf02 kernel:
>>>>>>>>> [11381.225489] Emily:drm_sched_cleanup_jobs,tid:2262, pid
>-Original Message-
>From: Grodzovsky, Andrey
>Sent: Tuesday, November 12, 2019 11:28 AM
>To: Koenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue
for tdr
>
>Thinking more about this claim - we
Grodzovsky, Andrey
>Sent: Tuesday, November 12, 2019 11:28 AM
>To: Koenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue
for tdr
>
>Thinking more about this claim - we assume here that if
cancel_delayed
e shouldn't have a guilty job in the first
place.
>>>
>>> Regards,
>>> Christian.
>>>
>>> Am 08.11.19 um 11:22 schrieb Deng, Emily:
>>>> Hi Chrisitan,
>>>> No, I am with the new branch and also has the patch. Even it
>>
ncel_delayed_work to
>cancel_delayed_work_sync to flush the timeout work as timeout work itself
>waits for schedule thread to be parked again when calling park_thread.
>
>Andrey
>
>________________________
>From: amd-gfx on behalf of
>Koenig, Christian
>S
delayed_work to
>cancel_delayed_work_sync to flush the timeout work as timeout work itself
>waits for schedule thread to be parked again when calling park_thread.
>
>Andrey
>
>____________________
>From: amd-gfx on behalf of
>Koenig, Christian
>Sent:
yed_work to
>cancel_delayed_work_sync to flush the timeout work as timeout work itself
>waits for schedule thread to be parked again when calling park_thread.
>
>Andrey
>
>____________
>From: amd-gfx on behalf of
>Koenig, Christian
>Sent: 08 Nov
have a guilty job in the first
place.
>>>
>>> Regards,
>>> Christian.
>>>
>>> Am 08.11.19 um 11:22 schrieb Deng, Emily:
>>>> Hi Chrisitan,
>>>> No, I am with the new branch and also has the patch. Even it
>>>> are free
b:f086ec84, tid:2262, pid:2262
>-Original Message-
>From: Grodzovsky, Andrey
>Sent: Tuesday, November 12, 2019 11:28 AM
>To: Koenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Thin
ovsky, Andrey
>Sent: Tuesday, November 12, 2019 11:28 AM
>To: Koenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Thinking more about this claim - we assume here that if cancel_delayed_work
>
oenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Thinking more about this claim - we assume here that if cancel_delayed_work
>returned true it guarantees that timeout work is not running but, it mere
Message-
>From: Grodzovsky, Andrey
>Sent: Tuesday, November 12, 2019 5:35 AM
>To: Deng, Emily ; Koenig, Christian
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Emily - is there a particular scenario to reproduce thi
en calling park_thread.
Andrey
From: amd-gfx on behalf of Koenig,
Christian
Sent: 08 November 2019 05:35:18
To: Deng, Emily; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Hi Emily,
exactly that
PM
To: Grodzovsky, Andrey ; Koenig, Christian
; amd-gfx@lists.freedesktop.org
Subject: RE: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
Hi Andrey,
I don’t think your patch will help for this. As it will may call
kthread_should_park in drm_sched_cleanup_jobs first, and then call
kcl_kthread
ber 9, 2019 3:01 AM
To: Koenig, Christian ; Deng, Emily
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
On 11/8/19 5:35 AM, Koenig, Christian wrote:
Hi Emily,
exactly that can't happen. See here:
/* Don't destroy jobs whi
t;From: amd-gfx On Behalf Of Deng,
>Emily
>Sent: Monday, November 11, 2019 3:19 PM
>To: Grodzovsky, Andrey ; Koenig, Christian
>; amd-gfx@lists.freedesktop.org
>Subject: RE: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Hi Andrey,
>I don’t think your patch will
zovsky, Andrey
>Sent: Saturday, November 9, 2019 3:01 AM
>To: Koenig, Christian ; Deng, Emily
>; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>
>On 11/8/19 5:35 AM, Koenig, Christian wrote:
>> Hi Emily,
>>
Deng
>
>
>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Friday, November 8, 2019 6:35 PM
>> To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>>
>> Hi Emily
;>
>>
>>> -----Original Message-----
>>> From: Koenig, Christian
>>> Sent: Friday, November 8, 2019 6:26 PM
>>> To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>>> Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>>
t;Sent: Friday, November 8, 2019 6:35 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Hi Emily,
>
>exactly that can't happen. See here:
>
>> /* Don't destroy jobs while the timeout
er. I mean the main scheduler free the jobs while in
> amdgpu_device_gpu_recover, and before calling drm_sched_stop.
>
> Best wishes
> Emily Deng
>
>
>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Friday, November 8, 2019 6:26 PM
>> To: Deng, Emily ; amd
Christian
>Sent: Friday, November 8, 2019 6:26 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Hi Emily,
>
>well who is calling amdgpu_device_gpu_recover() in this case?
>
>When it's not the sc
Sent: Friday, November 8, 2019 6:15 PM
>> To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>>
>> Hi Emily,
>>
>> in this case you are on an old code branch.
>>
>> Jobs are free
>Sent: Friday, November 8, 2019 6:15 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Hi Emily,
>
>in this case you are on an old code branch.
>
>Jobs are freed now by the main scheduler thread a
815374] ? kthread_create_worker_on_cpu+0x70/0x70
> [ 449.815799] ret_from_fork+0x35/0x40
>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Friday, November 8, 2019 5:43 PM
>> To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/amd
ovember 8, 2019 5:43 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Am 08.11.19 um 10:39 schrieb Deng, Emily:
>> Sorry, please take your time.
>
>Have you seen my other response a bit below?
>
&g
gger issues.
Regards,
Christian.
>
> Best wishes
> Emily Deng
>
>
>
>> -Original Message-
>> From: Koenig, Christian
>> Sent: Friday, November 8, 2019 5:08 PM
>> To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>> Subject: Re: [PATCH] drm/amdgpu:
Sorry, please take your time.
Best wishes
Emily Deng
>-Original Message-
>From: Koenig, Christian
>Sent: Friday, November 8, 2019 5:08 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>
8, 2019 10:56 AM
>> To: Koenig, Christian ; amd-
>> g...@lists.freedesktop.org
>> Subject: RE: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>>
>>> -Original Message-
>>> From: Christian König
>>> Sent: Thursday, November 7, 2019 7
Ping.
Best wishes
Emily Deng
>-Original Message-
>From: amd-gfx On Behalf Of Deng,
>Emily
>Sent: Friday, November 8, 2019 10:56 AM
>To: Koenig, Christian ; amd-
>g...@lists.freedesktop.org
>Subject: RE: [PATCH] drm/amdgpu: Fix the null pointer issue for
>-Original Message-
>From: Christian König
>Sent: Thursday, November 7, 2019 7:28 PM
>To: Deng, Emily ; amd-gfx@lists.freedesktop.org
>Subject: Re: [PATCH] drm/amdgpu: Fix the null pointer issue for tdr
>
>Am 07.11.19 um 11:25 schrieb Emily Deng:
>> When the j
Am 07.11.19 um 11:25 schrieb Emily Deng:
When the job is already signaled, the s_fence is freed. Then it will has
null pointer in amdgpu_device_gpu_recover.
NAK, the s_fence is only set to NULL when the job is destroyed. See
drm_sched_job_cleanup().
When you see a job without an s_fence then
39 matches
Mail list logo
