Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Grodzovsky, Andrey
o >>> >>>> -Original Message- >>>> From: Grodzovsky, Andrey >>>> Sent: 2019年9月12日 10:32 >>>> To: Chen, Guchun ; Zhou1, Tao >>>> ; amd-gfx@lists.freedesktop.org >>>> Cc: Deucher, Alexander >>>> Subje

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Christian König
年9月12日 10:32 To: Chen, Guchun ; Zhou1, Tao ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. That not what I meant. Let's say you handled one bad page interrupt and as a result have one bad page reserved. Now unrela

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Grodzovsky, Andrey
m the case you > mentioned. > > Regards, > Tao > >> -Original Message- >> From: Grodzovsky, Andrey >> Sent: 2019年9月12日 10:32 >> To: Chen, Guchun ; Zhou1, Tao >> ; amd-gfx@lists.freedesktop.org >> Cc: Deucher, Alexander >> Subjec

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-12 Thread Zhou1, Tao
> To: Chen, Guchun ; Zhou1, Tao > ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. > > That not what I meant. Let's say you handled one bad page interrupt and as > a result have one bad page reser

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. Comment inline. Regards, Guchun -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, September 11, 2019 10:41 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Chen, Guchun
Comment inline. Regards, Guchun -Original Message- From: Grodzovsky, Andrey Sent: Wednesday, September 11, 2019 10:41 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org Cc: Chen, Guchun ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context. On

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
On second though this will break  what about reserving bad pages when resetting GPU for non RAS error reason such as manual reset ,S3 or ring timeout, (amdgpu_ras_resume->amdgpu_ras_reset_gpu) so i will keep the code as is. Another possible issue in existing code - looks like no reservation wil

Re: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-11 Thread Grodzovsky, Andrey
I like this much more, I will relocate to amdgpu_umc_process_ras_data_cb an push. Andrey On 9/10/19 11:08 PM, Zhou1, Tao wrote: > amdgpu_ras_reserve_bad_pages is only used by umc block, so another approach > is to move it into amdgpu_umc_process_ras_data_cb. > Anyway, either way is OK and the p

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-10 Thread Chen, Guchun
Also it's irrelevant for this partilcular interrupt as this is generic RAS interrupt and not memory errors specific. [Guchun]One typo, it should be "particular", not " partilcular". With that fixed, the patch is: Reviewed-by: Guchun Chen -Original Message- From: Andrey Grodzovsky Sen

RE: [PATCH] drm/amdgpu: Fix mutex lock from atomic context.

2019-09-10 Thread Zhou1, Tao
amdgpu_ras_reserve_bad_pages is only used by umc block, so another approach is to move it into amdgpu_umc_process_ras_data_cb. Anyway, either way is OK and the patch is: Reviewed-by: Tao Zhou > -Original Message- > From: Andrey Grodzovsky > Sent: 2019年9月11日 3:41 > To: amd-gfx@lists.fre