RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-25 Thread He, Jacob
to:ckoenig.leichtzumer...@gmail.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Leave the old spm_vmid there is not a problem because other new spm enabled job will update it before it’s running and

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-25 Thread Christian König
sts.freedesktop.org <mailto:amd-gfx@lists.freedesktop.org> *Subject: *Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Leave the old spm_vmid there is not a problem because other new spm enabled job will update it before it’s running and other spm disabled job will not access spm_

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-24 Thread He, Jacob
freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Leave the old spm_vmid there is not a problem because other new spm enabled job will update it before it’s running and other spm disabled job will not access spm_vmid register. Do you have a hig

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-24 Thread Christian König
ckoenig.leichtzumer...@gmail.com>; He, Jacob <mailto:jacob...@amd.com>; amd-gfx@lists.freedesktop.org <mailto:amd-gfx@lists.freedesktop.org> *Subject: *RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace [AMD Official Use Only - Internal Distribution Only] That’s fine to me. -D

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-24 Thread He, Jacob
ailto:jacob...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace [AMD Official Use Only - Internal Distribution Only] That’s fine to me. -David From: Koenig, Christian Sent: Friday, February 21, 2020 1

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Zhou, David(ChunMing)
Jacob <mailto:jacob...@amd.com> Sent: Thursday, February 20, 2020 10:46 PM To: Zhou, David(ChunMing) <mailto:david1.z...@amd.com>; Koenig, Christian <mailto:christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [P

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Christian König
ChunMing) ; He, Jacob ; Koenig, Christian ; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace That would probably be a no-go, but we could enhance the kernel driver to update the RLC_SPM_VMID register with the reserved VMID. Handling that in usersp

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Deucher, Alexander
ob <mailto:jacob...@amd.com> Sent: Thursday, February 20, 2020 10:46 PM To: Zhou, David(ChunMing) <mailto:david1.z...@amd.com>; Koenig, Christian <mailto:christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-21 Thread Christian König
-gfx@lists.freedesktop.org *Subject:* RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace amdgpu_vm_reserve_vmid doesn’t return the reserved vmid back to user space. There is no chance for user mode driver to update RLC_SPM_VMID. Thanks Jacob *From: *He, Jacob <mailto:jacob...@amd.com>

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-20 Thread Zhou, David(ChunMing)
Zhou, David(ChunMing)<mailto:david1.z...@amd.com>; Koenig, Christian<mailto:christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Looks like amdgpu_vm_reserve_vmid could work, le

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-20 Thread He, Jacob
mer...@gmail.com> Sent: Wednesday, February 19, 2020 7:02 PM To: He, Jacob<mailto:jacob...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Am 19.02.20 um 11:15 schrieb Jacob He: > [WHY] >

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-20 Thread He, Jacob
.@amd.com>; Koenig, Christian<mailto:christian.koe...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Looks like amdgpu_vm_reserve_vmid could work, let me have a try to update the RLC_SPM_VMID

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-20 Thread He, Jacob
; He, Jacob<mailto:jacob...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace [AMD Official Use Only - Internal Distribution Only] Christian is right here, that will cause many problems for simp

RE: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-19 Thread Zhou, David(ChunMing)
/ amdgpu_vm_unreserve_vmid. -David -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Wednesday, February 19, 2020 7:03 PM To: He, Jacob ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace Am 19.02.20 um 11:15 schrieb Jacob He: > [WHY] > Wh

Re: [PATCH] drm/amdgpu: Add a chunk ID for spm trace

2020-02-19 Thread Christian König
Am 19.02.20 um 11:15 schrieb Jacob He: [WHY] When SPM trace enabled, SPM_VMID should be updated with the current vmid. [HOW] Add a chunk id, AMDGPU_CHUNK_ID_SPM_TRACE, so that UMD can tell us which job should update SPM_VMID. Right before a job is submitted to GPU, set the SPM_VMID accordingly.