Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-09 Thread Zhu, James
ATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+ Acked-by: Christian König Am 07.06.21 um 23:32 schrieb Zhang, Boyuan: > [AMD Official Use Only] > > Patch is > Reviewed-by: Boyuan Zhang > > Thanks, > Boyuan > > -Original Message- > From: amd-gfx On Behalf

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-08 Thread Christian König
Acked-by: Christian König Am 07.06.21 um 23:32 schrieb Zhang, Boyuan: [AMD Official Use Only] Patch is Reviewed-by: Boyuan Zhang Thanks, Boyuan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: June 7, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexa

RE: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Zhang, Boyuan
[AMD Official Use Only] Patch is Reviewed-by: Boyuan Zhang Thanks, Boyuan -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: June 7, 2021 4:29 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+ Drop

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Alex Deucher
On Mon, Jun 7, 2021 at 4:54 PM Ernst Sjöstrand wrote: > > Hi, > > doesn't this patch apply the change to VCN1.0 also, which has that bug you > mentioned? > Nope. VCN1.0 uses vcn_v1_0_idle_work_handler() and vcn_v1_0_ring_begin_use() as they have other special handling in addition to this. Alex

Re: [PATCH] drm/amdgpu/vcn: drop gfxoff control for VCN2+

2021-06-07 Thread Ernst Sjöstrand
Hi, doesn't this patch apply the change to VCN1.0 also, which has that bug you mentioned? Regards //Ernst Den mån 7 juni 2021 kl 22:29 skrev Alex Deucher : > Drop disabling of gfxoff during VCN use. This allows gfxoff > to kick in and potentially save power if the user is not using > gfx for c