RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-19 Thread Deng, Emily
Ok, thanks very much. Best wishes Emily Deng From: Koenig, Christian Sent: Thursday, September 19, 2019 5:06 PM To: Deng, Emily Cc: Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Teng, Rui ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough I

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-19 Thread Koenig, Christian
y ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org; Teng, Rui ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Reviewed & Tested-by: Jack Zhang mailto:jack.zha...@amd.com>> BR, Jack From: Deng, Emily mailto:emily.d...@amd.

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-19 Thread Deng, Emily
(Jian) mailto:jack.zha...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Teng, Rui mailto:rui.t...@amd.com>>; Cui, Flora mailto:flora@amd.com>> Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Hi Jack, Co

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Zhang, Jack (Jian)
t;> Cc: Zhang, Jack (Jian) mailto:jack.zha...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Teng, Rui mailto:rui.t...@amd.com>>; Cui, Flora mailto:flora@amd.com>> Subject: Re: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Deng, Emily
<mailto:jack.zha...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Teng, Rui <mailto:rui.t...@amd.com>; Cui, Flora <mailto:flora@amd.com> Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Yes, exactly. The pr

Re: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Deucher, Alexander
) Cc: Deng, Emily ; Cui, Flora ; Teng, Rui ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Hi Jack, Well that believe is unfortunately completely wrong. The point is that ANY use of amdgpu by userspace will prevent correct driver

Re: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Koenig, Christian
ilto:amd-gfx@lists.freedesktop.org>; Teng, Rui <mailto:rui.t...@amd.com>; Cui, Flora <mailto:flora@amd.com> Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Yes, exactly. The problem is that even when output is qxl or the Intel driver o

Re: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Koenig, Christian
ristian.koe...@amd.com>> Sent: Wednesday, September 18, 2019 4:44 PM To: Deng, Emily mailto:emily.d...@amd.com>> Cc: Zhang, Jack (Jian) mailto:jack.zha...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>; Teng, Rui mailto:rui.t...@amd.com>&

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Deng, Emily
, September 18, 2019 5:45 PM To: Deng, Emily Cc: Zhang, Jack (Jian) ; amd-gfx@lists.freedesktop.org; Teng, Rui ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Yes, exactly. The problem is that even when output is qxl or the Intel driver our driver is

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Koenig, Christian
ily.d...@amd.com>>; Cui, Flora mailto:flora....@amd.com>> Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Hi Jack, Well that believe is unfortunately completely wrong. The point is that ANY use of amdgpu by userspace will prevent correct driver un

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Deng, Emily
@lists.freedesktop.org; Teng, Rui ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Hi Emily, Yeah, exactly that's the problem: In some cases the driver can be unloaded while it is still in use! See we added this error message because endusers tried t

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Koenig, Christian
p.org; Teng, Rui ; Deng, Emily ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough Hi Jack, Well that believe is unfortunately completely wrong. The point is that ANY use of amdgpu by userspace will prevent correct driver unload, that qxl is use

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Deng, Emily
about driver unloading path? Best wishes Emily Deng From: Koenig, Christian Sent: Wednesday, September 18, 2019 3:54 PM To: Zhang, Jack (Jian) Cc: amd-gfx@lists.freedesktop.org; Teng, Rui ; Deng, Emily ; Cui, Flora Subject: RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Koenig, Christian
Hi Jack, Well that believe is unfortunately completely wrong. The point is that ANY use of amdgpu by userspace will prevent correct driver unload, that qxl is used for the fbcon doesn't change anything here. So the patch is a clear NAK. Driver unload is not supposed to work even under SRIOV.

RE: [PATCH] drm/amdgpu/sriov: omit fbcon error under sriov or passthrough

2019-09-18 Thread Zhang, Jack (Jian)
Hi, Christian and folks, In virtual machines(such virt-manager), there's always a virtual graphics device existed like "qxl" as the default gfx device. So under such condition, we believe it's reasonable to unload amdgpu driver as it is not treated as the default fbcon device. Would you please