RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Quan, Evan
Acked-by: Evan Quan > -Original Message- > From: amd-gfx On Behalf Of Yintian > Tao > Sent: Wednesday, December 11, 2019 10:51 AM > To: Deucher, Alexander ; Feng, Kenneth > > Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian > Subject: [PATCH] drm/amd/powerplay: enable pp one vf mode for

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] I assume the smu firmware has been changed accordingly. Reviewed-by: Kenneth Feng -Original Message- From: Yintian Tao Sent: Wednesday, December 11, 2019 10:51 AM To: Deucher, Alexander ; Feng, Kenneth Cc: amd-gfx@lists.freedeskto

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Feng, Kenneth
[AMD Official Use Only - Internal Distribution Only] -Original Message- From: Yintian Tao Sent: Wednesday, December 11, 2019 10:51 AM To: Deucher, Alexander ; Feng, Kenneth Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amd/powerplay: enable pp one vf mode for

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Quan, Evan
> + /* under pp_one_vf mode, vbios or hypervisor driver > + * has already copy table to smc so here only skip it > + */ > + if (!hwmgr->not_vf && !hwmgr->pp_one_vf) > + return 0; This code seems inconsistent with the comment. Maybe using "if (hwmgr->pp_one_vf)" is eno

Re: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Alex Deucher
() On Tue, Dec 10, 2019 at 4:36 AM Yintian Tao wrote: > > Originally, due to the restriction from PSP and SMU, VF has > to send message to hypervisor driver to handle powerplay > change which is complicated and redundant. Currently, SMU > and PSP can support VF to directly handle powerplay > chang

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-10 Thread Tao, Yintian
Ping... -Original Message- From: Yintian Tao Sent: 2019年12月10日 17:36 To: Deucher, Alexander ; Feng, Kenneth Cc: amd-gfx@lists.freedesktop.org; Tao, Yintian Subject: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10 Originally, due to the restriction from PSP and SMU, VF has

Re: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-09 Thread Alex Deucher
m: Alex Deucher > Sent: 2019年12月10日 0:52 > To: Tao, Yintian > Cc: Deucher, Alexander ; Feng, Kenneth > ; amd-gfx list > Subject: Re: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10 > > On Mon, Dec 9, 2019 at 5:39 AM Yintian Tao wrote: > > > > Origi

RE: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-09 Thread Tao, Yintian
-gfx list Subject: Re: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10 On Mon, Dec 9, 2019 at 5:39 AM Yintian Tao wrote: > > Originally, due to the restriction from PSP and SMU, VF has > to send message to hypervisor driver to handle powerplay > change which is com

Re: [PATCH] drm/amd/powerplay: enable pp one vf mode for vega10

2019-12-09 Thread Alex Deucher
On Mon, Dec 9, 2019 at 5:39 AM Yintian Tao wrote: > > Originally, due to the restriction from PSP and SMU, VF has > to send message to hypervisor driver to handle powerplay > change which is complicated and redundant. Currently, SMU > and PSP can support VF to directly handle powerplay > change by