Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Christian König
Am 20.01.21 um 15:16 schrieb Kazlauskas, Nicholas: On 2021-01-20 5:26 a.m., Christian König wrote: Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from wit

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Kazlauskas, Nicholas
On 2021-01-20 5:26 a.m., Christian König wrote: Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to alloc

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-20 Thread Christian König
Am 19.01.21 um 21:40 schrieb Bhawanpreet Lakha: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to allocate GPU memory and use a list in amdgpu_display_m

RE: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-19 Thread Chen, Guchun
[AMD Public Use] +da = kzalloc(sizeof(struct dal_allocation), GFP_KERNEL); This looks to be one coding style issue. It's better to modify it to kzalloc(sizeof(*da),...) https://www.kernel.org/doc/html/latest/process/coding-style.html#allocating-memory Regards, Guchun -Original Message

Re: [PATCH] drm/amd/display: Implement functions to let DC allocate GPU memory

2021-01-19 Thread Kazlauskas, Nicholas
On 2021-01-19 3:40 p.m., Bhawanpreet Lakha wrote: From: Harry Wentland [Why] DC needs to communicate with PM FW through GPU memory. In order to do so we need to be able to allocate memory from within DC. [How] Call amdgpu_bo_create_kernel to allocate GPU memory and use a list in amdgpu_display