Re: Changes to let KFD use render node VMs

2018-03-02 Thread Felix Kuehling
On 2018-03-02 01:07 PM, Christian König wrote: > Am 02.03.2018 um 17:38 schrieb Felix Kuehling: >> On 2018-03-02 02:43 AM, Christian König wrote: >>> Hi Felix, >>> >>> patch #3 looks good to me in general, but why do you need to cache the >>> pd_phys_addr? >>> >>> The BO already does that anyway, s

Re: Changes to let KFD use render node VMs

2018-03-02 Thread Christian König
Am 02.03.2018 um 17:38 schrieb Felix Kuehling: On 2018-03-02 02:43 AM, Christian König wrote: Hi Felix, patch #3 looks good to me in general, but why do you need to cache the pd_phys_addr? The BO already does that anyway, so you can just use amdgpu_bo_gpu_addr() for this which also makes some

Re: Changes to let KFD use render node VMs

2018-03-02 Thread Felix Kuehling
On 2018-03-02 02:43 AM, Christian König wrote: > Hi Felix, > > patch #3 looks good to me in general, but why do you need to cache the > pd_phys_addr? > > The BO already does that anyway, so you can just use > amdgpu_bo_gpu_addr() for this which also makes some additional checks > on debug builds.

Re: Changes to let KFD use render node VMs

2018-03-01 Thread Christian König
Hi Felix, patch #3 looks good to me in general, but why do you need to cache the pd_phys_addr? The BO already does that anyway, so you can just use amdgpu_bo_gpu_addr() for this which also makes some additional checks on debug builds. patch #5 well mixing power management into the VM funct

Re: Changes to let KFD use render node VMs

2018-03-01 Thread Christian König
Felix; amd-...@freedesktop.org; Koenig, Christian Subject: Re: Changes to let KFD use render node VMs Hi Felix, Out of patches, Could I ask what the difference of AMDGPU_VM_CONTEXT_COMPUTE/GFX is? After you merge kfd_vm to amdgpu_vm, does the difference still exist? Thanks, David Zhou On 2018年03月02日 06

Re: Changes to let KFD use render node VMs

2018-03-01 Thread zhoucm1
: Changes to let KFD use render node VMs Hi Felix, Out of patches, Could I ask what the difference of AMDGPU_VM_CONTEXT_COMPUTE/GFX is? After you merge kfd_vm to amdgpu_vm, does the difference still exist? Thanks, David Zhou On 2018年03月02日 06:58, Felix Kuehling wrote: Hi Christian, I have

Re: Changes to let KFD use render node VMs

2018-03-01 Thread Kuehling, Felix
, Christian Subject: Re: Changes to let KFD use render node VMs Hi Felix, Out of patches, Could I ask what the difference of AMDGPU_VM_CONTEXT_COMPUTE/GFX is? After you merge kfd_vm to amdgpu_vm, does the difference still exist? Thanks, David Zhou On 2018年03月02日 06:58, Felix Kuehling wrote: Hi

Re: Changes to let KFD use render node VMs

2018-03-01 Thread zhoucm1
Hi Felix, Out of patches, Could I ask what the difference of AMDGPU_VM_CONTEXT_COMPUTE/GFX is? After you merge kfd_vm to amdgpu_vm, does the difference still exist? Thanks, David Zhou On 2018年03月02日 06:58, Felix Kuehling wrote: Hi Christian, I have a working patch series against amd-kfg

Changes to let KFD use render node VMs

2018-03-01 Thread Felix Kuehling
Hi Christian, I have a working patch series against amd-kfg-staging that lets KFD use VMs from render node FDs, as we discussed. There are two patches in that series that touch amdgpu_vm.[ch] that I'd like your feedback on before I commit the changes to amd-kfd-staging and include them in my upstr