Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-26 Thread Felix Kuehling
On 2020-03-26 3:11, Pan, Xinhui wrote: 2020年3月26日 14:51,Koenig, Christian 写道: Am 26.03.2020 07:45 schrieb "Pan, Xinhui" : 2020年3月26日 14:36,Koenig, Christian 写道: Am 26.03.2020 07:15 schrieb "Pan, Xinhui" : 2020年3月26日 13:38,Koenig, Christian 写道: Yeah that's on my TODO list for qu

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-26 Thread Pan, Xinhui
> 2020年3月26日 14:51,Koenig, Christian 写道: > > > > Am 26.03.2020 07:45 schrieb "Pan, Xinhui" : > > > > 2020年3月26日 14:36,Koenig, Christian 写道: > > > > > > > > Am 26.03.2020 07:15 schrieb "Pan, Xinhui" : > > > > > > > 2020年3月26日 13:38,Koenig, Christian 写道: > > > > > > Yeah that's on my

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread Koenig, Christian
Am 26.03.2020 07:45 schrieb "Pan, Xinhui" : > 2020年3月26日 14:36,Koenig, Christian 写道: > > > > Am 26.03.2020 07:15 schrieb "Pan, Xinhui" : > > > > 2020年3月26日 13:38,Koenig, Christian 写道: > > > > Yeah that's on my TODO list for quite a while as well. > > > > But we even need three IB pools. One v

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread Pan, Xinhui
> 2020年3月26日 14:36,Koenig, Christian 写道: > > > > Am 26.03.2020 07:15 schrieb "Pan, Xinhui" : > > > > 2020年3月26日 13:38,Koenig, Christian 写道: > > > > Yeah that's on my TODO list for quite a while as well. > > > > But we even need three IB pools. One very small for the IB tests, one for >

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread Koenig, Christian
Am 26.03.2020 07:15 schrieb "Pan, Xinhui" : > 2020年3月26日 13:38,Koenig, Christian 写道: > > Yeah that's on my TODO list for quite a while as well. > > But we even need three IB pools. One very small for the IB tests, one for > direct VM updates and one for the rest. > > So please make the pool a

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread Pan, Xinhui
> 2020年3月26日 13:38,Koenig, Christian 写道: > > Yeah that's on my TODO list for quite a while as well. > > But we even need three IB pools. One very small for the IB tests, one for > direct VM updates and one for the rest. > > So please make the pool a parameter to ib_get() and not the hack you

Re: [RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread Koenig, Christian
Yeah that's on my TODO list for quite a while as well. But we even need three IB pools. One very small for the IB tests, one for direct VM updates and one for the rest. So please make the pool a parameter to ib_get() and not the hack you have below. Thanks, Christian. Am 26.03.2020 03:02 schri

[RFC PATCH 1/2] drm/amdgpu: add direct ib pool

2020-03-25 Thread xinhui pan
Another ib poll for direct submit. Any jobs schedule IBs without dependence on gpu scheduler should use this pool firstly. Signed-off-by: xinhui pan --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 12 +