Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-31 Thread Daniel Vetter
On Wed, Jul 31, 2019 at 10:25:15AM +0200, Christian König wrote: > Am 31.07.19 um 10:05 schrieb Daniel Vetter: > > [SNIP] > > > > Okay, I see now I was far off the mark with what I thought TTM_PL_SYSTEM > > > > was. The discussion helped clear up several bits of confusion on my > > > > part. > >

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-31 Thread Christian König
Am 31.07.19 um 10:05 schrieb Daniel Vetter: [SNIP] Okay, I see now I was far off the mark with what I thought TTM_PL_SYSTEM was. The discussion helped clear up several bits of confusion on my part. From proposed names, I find MAPPED and PINNED slightly confusing. In terms of backing store des

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-31 Thread Daniel Vetter
On Wed, Jul 31, 2019 at 8:54 AM Koenig, Christian wrote: > > Am 31.07.19 um 02:51 schrieb Brian Welty: > [SNIP] > >> +/* > >> + * Memory types for drm_mem_region > >> + */ > > #define DRM_MEM_SWAP? > btw what did you have in mind for this? Since we use shmem we kinda don't

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Koenig, Christian
Am 31.07.19 um 02:51 schrieb Brian Welty: [SNIP] >> +/* >> + * Memory types for drm_mem_region >> + */ > #define DRM_MEM_SWAP? btw what did you have in mind for this? Since we use shmem we kinda don't know whether the BO is actually swapped out or not, at least on the

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Brian Welty
On 7/30/2019 2:34 AM, Daniel Vetter wrote: > On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: >> Yeah, that looks like a good start. Just a couple of random design >> comments/requirements. >> >> First of all please restructure the changes so that you more or less >> have the f

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Brian Welty
On 7/30/2019 3:45 AM, Daniel Vetter wrote: > On Tue, Jul 30, 2019 at 12:24 PM Koenig, Christian > wrote: >> >> Am 30.07.19 um 11:38 schrieb Daniel Vetter: >>> On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: Snipped the feedback on struct drm_mem_region. Will be easier to have

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Daniel Vetter
On Tue, Jul 30, 2019 at 4:30 PM Michel Dänzer wrote: > On 2019-07-30 12:45 p.m., Daniel Vetter wrote: > > On Tue, Jul 30, 2019 at 12:24 PM Koenig, Christian > > wrote: > >> Am 30.07.19 um 11:38 schrieb Daniel Vetter: > >>> On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: > > > >

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Michel Dänzer
On 2019-07-30 12:45 p.m., Daniel Vetter wrote: > On Tue, Jul 30, 2019 at 12:24 PM Koenig, Christian > wrote: >> Am 30.07.19 um 11:38 schrieb Daniel Vetter: >>> On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: > > +#define DRM_MEM_SYSTEM 0 > +#define DRM_MEM_STOLEN

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Daniel Vetter
On Tue, Jul 30, 2019 at 12:24 PM Koenig, Christian wrote: > > Am 30.07.19 um 11:38 schrieb Daniel Vetter: > > On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: > >> Yeah, that looks like a good start. Just a couple of random design > >> comments/requirements. > >> > >> First of al

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Koenig, Christian
Am 30.07.19 um 11:38 schrieb Daniel Vetter: > On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: >> Yeah, that looks like a good start. Just a couple of random design >> comments/requirements. >> >> First of all please restructure the changes so that you more or less >> have the fol

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Daniel Vetter
On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: > Yeah, that looks like a good start. Just a couple of random design > comments/requirements. > > First of all please restructure the changes so that you more or less > have the following: > 1. Adding of the new structures and fu

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Daniel Vetter
On Tue, Jul 30, 2019 at 08:45:57AM +, Koenig, Christian wrote: > Yeah, that looks like a good start. Just a couple of random design > comments/requirements. > > First of all please restructure the changes so that you more or less > have the following: > 1. Adding of the new structures and fu

Re: [RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-30 Thread Koenig, Christian
Yeah, that looks like a good start. Just a couple of random design comments/requirements. First of all please restructure the changes so that you more or less have the following: 1. Adding of the new structures and functionality without any change to existing code. 2. Replacing the existing fun

[RFC PATCH 0/3] Propose new struct drm_mem_region

2019-07-29 Thread Brian Welty
[ By request, resending to include amd-gfx + intel-gfx. Since resending, I fixed the nit with ordering of header includes that Sam noted. ] This RFC series is first implementation of some ideas expressed earlier on dri-devel [1]. Some of the goals (open for much debate) are: - Create common