Re: [RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Matthew Brost
On Fri, Sep 06, 2024 at 07:06:14PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In a recent conversation with Christian there was a thought that > drm_sched_entity_modify_sched() should start using the entity->rq_lock to be > safe against job submission and simultaneous priority change

Re: [RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Tvrtko Ursulin
On 09/09/2024 09:47, Philipp Stanner wrote: Hi, On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In a recent conversation with Christian there was a thought that drm_sched_entity_modify_sched() should start using the entity- rq_lock to be safe against job subm

Re: [RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-09 Thread Philipp Stanner
Hi, On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In a recent conversation with Christian there was a thought that > drm_sched_entity_modify_sched() should start using the entity- > >rq_lock to be > safe against job submission and simultaneous priority chang

[RFC 0/4] DRM scheduler fixes, or not, or incorrect kind

2024-09-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In a recent conversation with Christian there was a thought that drm_sched_entity_modify_sched() should start using the entity->rq_lock to be safe against job submission and simultaneous priority changes. The kerneldoc accompanying that function however is a bit unclear to m