Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-16 Thread Mauro Rossi
Hi Harry, in this thread some of the coding changes with open points, as a checklist/track for review of upcoming (v2) patches. M. On Mon, Oct 15, 2018 at 11:06 PM Harry Wentland wrote: > > On 2018-10-14 5:47 p.m., Mauro Rossi wrote: > > Hi, > > > > reporting about some progress made during the w

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-16 Thread Mauro Rossi
Hi Harry, thanks a lot for response, On Mon, Oct 15, 2018 at 11:19 PM Harry Wentland wrote: > > On 2018-10-15 5:06 p.m., Harry Wentland wrote: > > On 2018-10-14 5:47 p.m., Mauro Rossi wrote: > >> Hi, > >> > >> reporting about some progress made during the weekend, > >> thanks to Sylvain feedback

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Harry Wentland
On 2018-10-15 5:06 p.m., Harry Wentland wrote: > On 2018-10-14 5:47 p.m., Mauro Rossi wrote: >> Hi, >> >> reporting about some progress made during the weekend, >> thanks to Sylvain feedback & suggestions. >> >> I have rebased and updated the series on top of >> https://cgit.freedesktop.org/~agd5f/

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Harry Wentland
On 2018-10-14 5:47 p.m., Mauro Rossi wrote: > Hi, > > reporting about some progress made during the weekend, > thanks to Sylvain feedback & suggestions. > > I have rebased and updated the series on top of > https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-drm-next > > Here is the amd_dc_

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread Deucher, Alexander
current APIs in the "powerplay" code. Alex From: sylvain.bertr...@gmail.com Sent: Monday, October 15, 2018 8:45 AM To: Mauro Rossi Cc: amd-gfx@lists.freedesktop.org; Wentland, Harry; Deucher, Alexander; Mike Lothian Subject: Re: [RFC] drm/amd/display:

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-15 Thread sylvain . bertrand
On Mon, Oct 15, 2018 at 07:28:57AM +0200, Mauro Rossi wrote: > dpm for SI is available, while powerplay for SI is not, but > display/amdgpu_dm uses some powerplay calls, where get_static_clock > functions not available and the *ERROR* DM_PPLIB is due to missing handling > in powerplay I though pow

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-14 Thread Mauro Rossi
Hi Sylvain, Il lun 15 ott 2018, 03:25 ha scritto: > On Sun, Oct 14, 2018 at 11:47:18PM +0200, Mauro Rossi wrote: > > DOUBT: I think that it would make sense to set "power level 0" i.e. > > the "lower state" as safe default, > > considering that powerplay smu6/hwmgr are not implemented for SI and

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-14 Thread sylvain . bertrand
On Sun, Oct 14, 2018 at 11:47:18PM +0200, Mauro Rossi wrote: > DOUBT: I think that it would make sense to set "power level 0" i.e. > the "lower state" as safe default, > considering that powerplay smu6/hwmgr are not implemented for SI and > smu7 CIK functions do not work, > the AS-IS dpm is the onl

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-14 Thread Mauro Rossi
Hi, reporting about some progress made during the weekend, thanks to Sylvain feedback & suggestions. I have rebased and updated the series on top of https://cgit.freedesktop.org/~agd5f/linux/?h=amd-staging-drm-next Here is the amd_dc_si branch: https://github.com/maurossi/linux/tree/amd_dc_si (u

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 08:17:06PM +, sylvain.bertr...@gmail.com wrote: > Sorry, I was wrong: I thought your patch set was enabling by default DC for > dce6 (it requires the DC kernel param). > I did force it, and it fails to init the dce6. I did hack a bit your patch set on amd-staging-drm-ne

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 07:02:54PM +0200, Mauro Rossi wrote: > Thanks for info, do you have some github or patch to share for > comparison/mutual knowledge? Sorry, I was wrong: I thought your patch set was enabling by default DC for dce6 (it requires the DC kernel param). I did force it, and it fa

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mauro Rossi
Hi Sylvain, On Mon, Oct 8, 2018 at 2:04 PM wrote: > > I am currently testing your patch set, on amd-staging-drm-next > (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a > displayport monitor. > patch02 drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c did not apply

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Deucher, Alexander
ns. Alex From: amd-gfx on behalf of Mike Lothian Sent: Monday, October 8, 2018 8:16:01 AM To: Koenig, Christian Cc: Mauro Rossi; Wentland, Harry; amd-gfx@lists.freedesktop.org Subject: Re: [RFC] drm/amd/display: add SI support to AMD DC I thought it just required th

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
On Mon, Oct 08, 2018 at 12:04:23PM +, sylvain.bertr...@gmail.com wrote: > I am currently testing your patch set, on amd-staging-drm-next > (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a > displayport monitor. Forgot a very important thing: I run it with the linux t

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
I thought it just required the existing firmware, with padding / extra info put around it? On Mon, 8 Oct 2018 at 12:29 Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > UVD/VCE on SI with amdgpu would need new firmware. > > And so far we never had time to actually look into releasing t

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread sylvain . bertrand
I am currently testing your patch set, on amd-staging-drm-next (380d480842d584278dba9aa74341017d8c7d8c23) with an AMD tahiti xt part and a displayport monitor. patch02 drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c did not apply but seems kind of benign. It's working out of the box on my AM

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Christian König
UVD/VCE on SI with amdgpu would need new firmware. And so far we never had time to actually look into releasing that firmware. Regards, Christian. Am 08.10.2018 um 13:22 schrieb Mauro Rossi: Hi Mike, On Mon, Oct 8, 2018 at 1:00 PM Mike Lothian > wrote: Hi Maur

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mauro Rossi
Hi Mike, On Mon, Oct 8, 2018 at 1:00 PM Mike Lothian wrote: > Hi Mauro > > Do you know if there are any plans to add in UVD support on SI too? > > Thanks > > Mike > At the moment my focus is on getting a conformant, working and stable implementation of Atomic Display Framework, with the objectiv

Re: [RFC] drm/amd/display: add SI support to AMD DC

2018-10-08 Thread Mike Lothian
Hi Mauro Do you know if there are any plans to add in UVD support on SI too? Thanks Mike On Mon, 8 Oct 2018 at 03:24 Mauro Rossi wrote: > [PATCH 01/10] drm/amd/display: add asics info for SI parts > [PATCH 02/10] drm/amd/display: dc/dce: add DCE6 support > [PATCH 03/10] drm/amd/display: dc/co

[RFC] drm/amd/display: add SI support to AMD DC

2018-10-07 Thread Mauro Rossi
[PATCH 01/10] drm/amd/display: add asics info for SI parts [PATCH 02/10] drm/amd/display: dc/dce: add DCE6 support [PATCH 03/10] drm/amd/display: dc/core: add DCE6 support [PATCH 04/10] drm/amd/display: dc/bios: add support for DCE6 [PATCH 05/10] drm/amd/display: dc/gpio: add support for DCE6 [PATC