Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-12 Thread Zhu Lingshan
On 11/13/2024 7:46 AM, Felix Kuehling wrote: > > On 2024-11-12 2:35, Zhu Lingshan wrote: >> On 11/12/2024 6:21 AM, Felix Kuehling wrote: >>> On 2024-11-11 03:08, Zhu Lingshan wrote: On 11/5/2024 4:50 AM, Felix Kuehling wrote: > On 2024-10-31 22:35, Zhu Lingshan wrote: >> On 10/31/2024

Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-12 Thread Felix Kuehling
On 2024-11-12 2:35, Zhu Lingshan wrote: > On 11/12/2024 6:21 AM, Felix Kuehling wrote: >> >> On 2024-11-11 03:08, Zhu Lingshan wrote: >>> On 11/5/2024 4:50 AM, Felix Kuehling wrote: On 2024-10-31 22:35, Zhu Lingshan wrote: > On 10/31/2024 11:30 PM, Felix Kuehling wrote: >> On 2024-1

Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-11 Thread Zhu Lingshan
On 11/12/2024 6:21 AM, Felix Kuehling wrote: > > On 2024-11-11 03:08, Zhu Lingshan wrote: >> On 11/5/2024 4:50 AM, Felix Kuehling wrote: >>> On 2024-10-31 22:35, Zhu Lingshan wrote: On 10/31/2024 11:30 PM, Felix Kuehling wrote: > On 2024-10-31 6:50, Zhu Lingshan wrote: >> The ioctl fun

Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-11 Thread Felix Kuehling
On 2024-11-11 03:08, Zhu Lingshan wrote: On 11/5/2024 4:50 AM, Felix Kuehling wrote: On 2024-10-31 22:35, Zhu Lingshan wrote: On 10/31/2024 11:30 PM, Felix Kuehling wrote: On 2024-10-31 6:50, Zhu Lingshan wrote: The ioctl functions may fail, causing the args unreliable. Therefore, the args

Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-11 Thread Zhu Lingshan
On 11/5/2024 4:50 AM, Felix Kuehling wrote: > > On 2024-10-31 22:35, Zhu Lingshan wrote: >> On 10/31/2024 11:30 PM, Felix Kuehling wrote: >>> On 2024-10-31 6:50, Zhu Lingshan wrote: The ioctl functions may fail, causing the args unreliable. Therefore, the args should not be copied to user

Re: [RESEND] amdkfd: check ret code for ioctls

2024-11-04 Thread Felix Kuehling
On 2024-10-31 22:35, Zhu Lingshan wrote: > On 10/31/2024 11:30 PM, Felix Kuehling wrote: >> >> On 2024-10-31 6:50, Zhu Lingshan wrote: >>> The ioctl functions may fail, causing the args unreliable. >>> Therefore, the args should not be copied to user space. >>> >>> The return code provides enoug

Re: [RESEND] amdkfd: check ret code for ioctls

2024-10-31 Thread Zhu Lingshan
On 10/31/2024 11:30 PM, Felix Kuehling wrote: > > On 2024-10-31 6:50, Zhu Lingshan wrote: >> The ioctl functions may fail, causing the args unreliable. >> Therefore, the args should not be copied to user space. >> >> The return code provides enough information for >> error handling in user space. >

Re: [RESEND] amdkfd: check ret code for ioctls

2024-10-31 Thread Felix Kuehling
On 2024-10-31 6:50, Zhu Lingshan wrote: > The ioctl functions may fail, causing the args unreliable. > Therefore, the args should not be copied to user space. > > The return code provides enough information for > error handling in user space. > > This commit checks the return code of the ioctl

[RESEND] amdkfd: check ret code for ioctls

2024-10-31 Thread Zhu Lingshan
The ioctl functions may fail, causing the args unreliable. Therefore, the args should not be copied to user space. The return code provides enough information for error handling in user space. This commit checks the return code of the ioctl functions and handles errors appropriately when they fai