RE: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-14 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] > From: Tvrtko Ursulin > Sent: Wednesday, November 13, 2024 12:31 > On 13/11/2024 17:01, Li, Yunxiang (Teddy) wrote: > > [Public] > > > >> From: Koenig, Christian > >> Sent: Wednesday, November 13, 2024 9:22 Am 13.11.24 um 14:53 schrieb >

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-14 Thread Matthew Auld
Hi, On 13/11/2024 17:30, Tvrtko Ursulin wrote: On 13/11/2024 17:01, Li, Yunxiang (Teddy) wrote: [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024 9:22 Am 13.11.24 um 14:53 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-14 Thread Tvrtko Ursulin
On 13/11/2024 17:01, Li, Yunxiang (Teddy) wrote: [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024 9:22 Am 13.11.24 um 14:53 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024 6:39 Am 13.11.24 um 11:25 schrieb Tvrtko Ursuli

RE: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Li, Yunxiang (Teddy)
[Public] > From: Koenig, Christian > Sent: Wednesday, November 13, 2024 9:22 > Am 13.11.24 um 14:53 schrieb Li, Yunxiang (Teddy): > > [Public] > > > >> From: Koenig, Christian > >> Sent: Wednesday, November 13, 2024 6:39 Am 13.11.24 um 11:25 schrieb > >> Tvrtko Ursulin: > >>> On 13/11/2024 08:49

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Christian König
Am 13.11.24 um 14:53 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024 6:39 Am 13.11.24 um 11:25 schrieb Tvrtko Ursulin: On 13/11/2024 08:49, Christian König wrote: Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): [SNIP] + size = sign * a

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Christian König
Am 13.11.24 um 15:09 schrieb Li, Yunxiang (Teddy): [Public] From: Koenig, Christian Sent: Wednesday, November 13, 2024 3:49 Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): From: Christian König Sent: Tuesday, November 12, 2024 5:54 Am 10.11.24 um 16:41 schrieb Yunxiang Li: @@ -2612,7 +27

RE: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Li, Yunxiang (Teddy)
[Public] > From: Koenig, Christian > Sent: Wednesday, November 13, 2024 3:49 > Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): > >> From: Christian König > >> Sent: Tuesday, November 12, 2024 5:54 > >> Am 10.11.24 um 16:41 schrieb Yunxiang Li: > >>> @@ -2612,7 +2707,6 @@ void amdgpu_vm_fini(s

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Tvrtko Ursulin
On 13/11/2024 08:49, Christian König wrote: Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): [Public] From: Christian König Sent: Tuesday, November 12, 2024 5:54 Am 10.11.24 um 16:41 schrieb Yunxiang Li: @@ -310,6 +311,92 @@ static void amdgpu_vm_bo_reset_state_machine(struct amdgpu_vm

RE: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Li, Yunxiang (Teddy)
[Public] > From: Koenig, Christian > Sent: Wednesday, November 13, 2024 6:39 > Am 13.11.24 um 11:25 schrieb Tvrtko Ursulin: > > On 13/11/2024 08:49, Christian König wrote: > >> Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): > >>> [SNIP] > > + size = sign * amdgpu_bo_size(bo); > > +

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Christian König
Am 13.11.24 um 11:25 schrieb Tvrtko Ursulin: On 13/11/2024 08:49, Christian König wrote: Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): [SNIP] +   size = sign * amdgpu_bo_size(bo); +   res = bo->tbo.resource; +   type = res ? res->mem_type : amdgpu_bo_get_preferred_placement(bo); Again,

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-13 Thread Christian König
Am 12.11.24 um 19:16 schrieb Li, Yunxiang (Teddy): [Public] From: Christian König Sent: Tuesday, November 12, 2024 5:54 Am 10.11.24 um 16:41 schrieb Yunxiang Li: @@ -310,6 +311,92 @@ static void amdgpu_vm_bo_reset_state_machine(struct amdgpu_vm *vm) spin_unlock(&vm->status_lock); }

RE: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-12 Thread Li, Yunxiang (Teddy)
[Public] > From: Christian König > Sent: Tuesday, November 12, 2024 5:54 > Am 10.11.24 um 16:41 schrieb Yunxiang Li: > > @@ -310,6 +311,92 @@ static void amdgpu_vm_bo_reset_state_machine(struct > amdgpu_vm *vm) > > spin_unlock(&vm->status_lock); > > } > > > > +/** > > + * amdgpu_vm_update_s

Re: [PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-12 Thread Christian König
Am 10.11.24 um 16:41 schrieb Yunxiang Li: Before, every time fdinfo is queried we try to lock all the BOs in the VM and calculate memory usage from scratch. This works okay if the fdinfo is rarely read and the VMs don't have a ton of BOs. If either of these conditions is not true, we get a massiv

[PATCH v7 4/4] drm/amdgpu: track bo memory stats at runtime

2024-11-10 Thread Yunxiang Li
Before, every time fdinfo is queried we try to lock all the BOs in the VM and calculate memory usage from scratch. This works okay if the fdinfo is rarely read and the VMs don't have a ton of BOs. If either of these conditions is not true, we get a massive performance hit. In this new revision, we