Re: [PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Bhardwaj, Rajneesh
shank *From:* Bhardwaj, Rajneesh *Sent:* Monday, March 18, 2024 3:04 PM *To:* Sharma, Shashank ; amd-gfx@lists.freedesktop.org *Cc:* Koenig, Christian ; Deucher, Alexander ; Kuehling, Felix *Subject:* Re: [PATCH v7 2/2] drm/amdgpu: sync page table fr

Re: [PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Sharma, Shashank
p.org Cc: Koenig, Christian ; Deucher, Alexander ; Kuehling, Felix Subject: Re: [PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush HI Shashank We'll probably need a v8 with the null pointer crash fixed i.e. before freeing the PT entries check for a valid entry befo

Re: [PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Bhardwaj, Rajneesh
HI Shashank We'll probably need a v8 with the null pointer crash fixed i.e. before freeing the PT entries check for a valid entry before calling amdgpu_vm_pt_free. The crash is seen with device memory allocators but the system memory allocators are looking fine. [  127.255863] [drm] Using MT

[PATCH v7 2/2] drm/amdgpu: sync page table freeing with tlb flush

2024-03-18 Thread Shashank Sharma
The idea behind this patch is to delay the freeing of PT entry objects until the TLB flush is done. This patch: - Adds a tlb_flush_waitlist in amdgpu_vm_update_params which will keep the objects that need to be freed after tlb_flush. - Adds PT entries in this list in amdgpu_vm_ptes_update after