Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Mario Limonciello
On 11/26/24 09:37, Lazar, Lijo wrote: On 11/26/2024 7:50 PM, Mario Limonciello wrote: Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? Then hibernate would fail under

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Lazar, Lijo
On 11/26/2024 7:50 PM, Mario Limonciello wrote: Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? >>> >>> Then hibernate would fail under memory pressure.

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Mario Limonciello
Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? Then hibernate would fail under memory pressure. My take is this failure with hibernate is a userspace problem (whether use

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Lazar, Lijo
On 11/25/2024 9:46 PM, Mario Limonciello wrote: > > > On 11/25/24 08:59, Lazar, Lijo wrote: >> >> >> On 11/25/2024 12:30 AM, Mario Limonciello wrote: >>> From: Mario Limonciello >>> >>> As part of the suspend sequence VRAM needs to be evicted on dGPUs. >>> In order to make suspend/resume more

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-25 Thread Mario Limonciello
On 11/25/24 08:59, Lazar, Lijo wrote: On 11/25/2024 12:30 AM, Mario Limonciello wrote: From: Mario Limonciello As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspe

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-25 Thread Lazar, Lijo
On 11/25/2024 12:30 AM, Mario Limonciello wrote: > From: Mario Limonciello > > As part of the suspend sequence VRAM needs to be evicted on dGPUs. > In order to make suspend/resume more reliable we moved this into > the pmops prepare() callback so that the suspend sequence would fail > but the

[PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-24 Thread Mario Limonciello
From: Mario Limonciello As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspend sequence would fail but the system could remain operational under high memory usage suspend.