Emily
<mailto:emily.d...@amd.com>; amd-gfx@lists.freedesktop.org
*Subject:* Re: [PATCH v4] drm/amdgpu: Fix the race condition for
draining retry fault
Thanks for catch up and fix this race condition. It looks good to
me. One minor thing below:
On 3/6/2025 12:03 AM, Emil
Thanks for catch up and fix this race condition. It looks good to me.
One minor thing below:
On 3/6/2025 12:03 AM, Emily Deng wrote:
Issue:
In the scenario where svm_range_restore_pages is called, but svm->checkpoint_ts
has not been set and the retry fault has not been drained,
svm_range_unm
[AMD Official Use Only - AMD Internal Distribution Only]
From: Chen, Xiaogang
Sent: Saturday, March 8, 2025 8:38 AM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4] drm/amdgpu: Fix the race condition for draining retry
fault
On 3/6/2025 7:27 PM, Deng, Emily wrote
On 3/6/2025 7:27 PM, Deng, Emily wrote:
[AMD Official Use Only - AMD Internal Distribution Only]
*From:*Chen, Xiaogang
*Sent:* Friday, March 7, 2025 1:01 AM
*To:* Deng, Emily ; amd-gfx@lists.freedesktop.org
*Subject:* Re: [PATCH v4] drm/amdgpu: Fix the race condition for
draining retry
[AMD Official Use Only - AMD Internal Distribution Only]
From: Chen, Xiaogang
Sent: Friday, March 7, 2025 1:01 AM
To: Deng, Emily ; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v4] drm/amdgpu: Fix the race condition for draining retry
fault
Thanks for catch up and fix this race
On 2025-03-06 1:03, Emily Deng wrote:
> Issue:
> In the scenario where svm_range_restore_pages is called, but
> svm->checkpoint_ts
> has not been set and the retry fault has not been drained,
> svm_range_unmap_from_cpu
> is triggered and calls svm_range_free. Meanwhile, svm_range_restore_pages
Issue:
In the scenario where svm_range_restore_pages is called, but svm->checkpoint_ts
has not been set and the retry fault has not been drained,
svm_range_unmap_from_cpu
is triggered and calls svm_range_free. Meanwhile, svm_range_restore_pages
continues execution and reaches svm_range_from_addr.
