Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-30 Thread Alex Deucher
On Thu, Mar 30, 2023 at 6:40 AM Christian König wrote: > > Am 30.03.23 um 10:15 schrieb Shashank Sharma: > > Hello Pierre-Eric, > > [SNIP] > >> I'm also wondering why the doorbell needs a handle+offset but > >> other buffers are passed in as virtual addresses? > >> > > As you know, doorbell offset

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-30 Thread Christian König
Am 30.03.23 um 10:15 schrieb Shashank Sharma: Hello Pierre-Eric, [SNIP] I'm also wondering why the doorbell needs a handle+offset but other buffers are passed in as virtual addresses? As you know, doorbell offset here will be an relative offset in this doorbell page, but the MQD needs the abso

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-30 Thread Shashank Sharma
Hello Pierre-Eric, Thanks for your review, my comments inline. On 30/03/2023 10:02, Pierre-Eric Pelloux-Prayer wrote: Hi Shashank, On 29/03/2023 18:04, Shashank Sharma wrote: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill th

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Shashank Sharma
On 29/03/2023 21:46, Alex Deucher wrote: On Wed, Mar 29, 2023 at 3:21 PM Shashank Sharma wrote: Hey Alex, On 29/03/2023 19:57, Alex Deucher wrote: On Wed, Mar 29, 2023 at 12:05 PM Shashank Sharma wrote: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue.

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Alex Deucher
On Wed, Mar 29, 2023 at 3:21 PM Shashank Sharma wrote: > > Hey Alex, > > On 29/03/2023 19:57, Alex Deucher wrote: > > On Wed, Mar 29, 2023 at 12:05 PM Shashank Sharma > > wrote: > >> From: Alex Deucher > >> > >> This patch intorduces new UAPI/IOCTL for usermode graphics > >> queue. The userspace

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Shashank Sharma
Hey Alex, On 29/03/2023 19:57, Alex Deucher wrote: On Wed, Mar 29, 2023 at 12:05 PM Shashank Sharma wrote: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work qu

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Alex Deucher
On Wed, Mar 29, 2023 at 12:05 PM Shashank Sharma wrote: > > From: Alex Deucher > > This patch intorduces new UAPI/IOCTL for usermode graphics > queue. The userspace app will fill this structure and request > the graphics driver to add a graphics work queue for it. The > output of this UAPI is a q

Re: [PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Christian König
Am 29.03.23 um 18:04 schrieb Shashank Sharma: From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work queue for it. The output of this UAPI is a queue id. This UAPI ma

[PATCH v3 1/9] drm/amdgpu: UAPI for user queue management

2023-03-29 Thread Shashank Sharma
From: Alex Deucher This patch intorduces new UAPI/IOCTL for usermode graphics queue. The userspace app will fill this structure and request the graphics driver to add a graphics work queue for it. The output of this UAPI is a queue id. This UAPI maps the queue into GPU, so the graphics app can s