Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-21 Thread Maxime Ripard
On Thu, Jun 20, 2024 at 09:00:23AM GMT, Alex Deucher wrote: > On Thu, Jun 20, 2024 at 3:10 AM Maxime Ripard wrote: > > > > Hi, > > > > On Wed, Jun 19, 2024 at 09:53:12AM GMT, Alex Deucher wrote: > > > On Wed, Jun 19, 2024 at 9:50 AM Alex Deucher > > > wrote: > > > > > > > > On Tue, Jun 18, 2024

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-20 Thread Alex Deucher
On Thu, Jun 20, 2024 at 3:10 AM Maxime Ripard wrote: > > Hi, > > On Wed, Jun 19, 2024 at 09:53:12AM GMT, Alex Deucher wrote: > > On Wed, Jun 19, 2024 at 9:50 AM Alex Deucher wrote: > > > > > > On Tue, Jun 18, 2024 at 7:53 PM Doug Anderson > > > wrote: > > > > > > > > Hi, > > > > > > > > On Tue,

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-20 Thread Maxime Ripard
Hi, On Wed, Jun 19, 2024 at 09:53:12AM GMT, Alex Deucher wrote: > On Wed, Jun 19, 2024 at 9:50 AM Alex Deucher wrote: > > > > On Tue, Jun 18, 2024 at 7:53 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher > > > wrote: > > > > > > > > On Tue, Jun 1

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-19 Thread Alex Deucher
On Wed, Jun 19, 2024 at 9:50 AM Alex Deucher wrote: > > On Tue, Jun 18, 2024 at 7:53 PM Doug Anderson wrote: > > > > Hi, > > > > On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher wrote: > > > > > > On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson > > > wrote: > > > > > > > > Hi, > > > > > > > > > > >

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-19 Thread Alex Deucher
On Tue, Jun 18, 2024 at 7:53 PM Doug Anderson wrote: > > Hi, > > On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher wrote: > > > > On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > > > > > Hi, > > > > > > > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher > > > wrote: > > > > > > > > On Wed,

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Tue, Jun 18, 2024 at 3:00 PM Alex Deucher wrote: > > On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > > > Hi, > > > > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > > wrote: > > > > > > > > Based on grepp

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Alex Deucher
On Tue, Jun 18, 2024 at 5:40 PM Doug Anderson wrote: > > Hi, > > > On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > > wrote: > > > > > > Based on grepping through the source code this driver appears to be > > > missing a call to drm_

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-18 Thread Doug Anderson
Hi, On Mon, Jun 17, 2024 at 8:01 AM Alex Deucher wrote: > > On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson > wrote: > > > > Based on grepping through the source code this driver appears to be > > missing a call to drm_atomic_helper_shutdown() at system shutdown > > time. Among other things,

Re: [PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-17 Thread Alex Deucher
On Wed, Jun 12, 2024 at 6:37 PM Douglas Anderson wrote: > > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered of

[PATCH v2 8/8] drm/amdgpu: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-12 Thread Douglas Anderson
Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't be cleanly powered off at system shutdown time. The fact that we should call drm_atomic