Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-06 Thread jim . cromie
On Wed, Sep 6, 2023 at 10:42 AM Rodrigo Vivi wrote: > > On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote: > > Hi Jim, > > > > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > > > By at least strong convention, a print-buffer's trailing newline says > > > "message complete, s

Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-06 Thread Rodrigo Vivi
On Mon, Sep 04, 2023 at 08:32:40AM +0200, Andi Shyti wrote: > Hi Jim, > > On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > > By at least strong convention, a print-buffer's trailing newline says > > "message complete, send it". The exception (no TNL, followed by a call > > to pr_cont

Re: [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Andi Shyti
Hi Jim, On Sun, Sep 03, 2023 at 12:46:00PM -0600, Jim Cromie wrote: > By at least strong convention, a print-buffer's trailing newline says > "message complete, send it". The exception (no TNL, followed by a call > to pr_cont) proves the general rule. > > Most DRM.debug calls already comport wit

[PATCH v2 3/6] drm_dbg: add trailing newlines to msgs

2023-09-03 Thread Jim Cromie
By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintaine