Christian
> >
> > *Sent:* March 23, 2022 11:25
> > *To:* Daniel Vetter ; Daniel Stone
> > ; Olsak, Marek
> > ; Grodzovsky, Andrey
> >
> > *Cc:* Rob Clark ; Rob Clark
> > ; Sharma, Shashank
> > ; Christian König
> > ;
> >
--
> *From:* Koenig, Christian
>
> *Sent:* March 23, 2022 11:25
> *To:* Daniel Vetter ; Daniel Stone
> ; Olsak, Marek
> ; Grodzovsky, Andrey
>
> *Cc:* Rob Clark ; Rob Clark
> ; Sharma, Shashank
> ; Christian König
> ;
>
bject:* Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event
[Adding Marek and Andrey as well]
Am 23.03.22 um 16:14 schrieb Daniel Vetter:
> On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote:
>> Hi,
>>
>> On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote:
>>> On Mon, Mar 21, 20
drey
Cc: Rob Clark ; Rob Clark ;
Sharma, Shashank ; Christian König
; Somalapuram, Amaranath
; Abhinav Kumar ;
dri-devel ; amd-gfx list
; Deucher, Alexander
; Shashank Sharma
Subject: Re: [PATCH v2 1/2] drm: Add GPU reset sysfs event
[Adding Marek and Andrey as well]
Am 23.03.22 um 16:14 s
On Wed, Mar 23, 2022 at 8:14 AM Daniel Vetter wrote:
>
> On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote:
> >
> > Hi,
> >
> > On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote:
> > > On Mon, Mar 21, 2022 at 2:30 AM Christian König
> > > wrote:
> > > > Well you can, it just means that their context
[Adding Marek and Andrey as well]
Am 23.03.22 um 16:14 schrieb Daniel Vetter:
On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote:
Hi,
On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote:
On Mon, Mar 21, 2022 at 2:30 AM Christian König
wrote:
Well you can, it just means that their contexts are los
On Wed, 23 Mar 2022 at 15:07, Daniel Stone wrote:
>
> Hi,
>
> On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote:
> > On Mon, Mar 21, 2022 at 2:30 AM Christian König
> > wrote:
> > > Well you can, it just means that their contexts are lost as well.
> >
> > Which is rather inconvenient when deqp-egl r
Hi,
On Mon, 21 Mar 2022 at 16:02, Rob Clark wrote:
> On Mon, Mar 21, 2022 at 2:30 AM Christian König
> wrote:
> > Well you can, it just means that their contexts are lost as well.
>
> Which is rather inconvenient when deqp-egl reset tests, for example,
> take down your compositor ;-)
Yeah. Or a
On Mon, Mar 21, 2022 at 2:30 AM Christian König
wrote:
>
> Am 18.03.22 um 16:12 schrieb Rob Clark:
> > On Fri, Mar 18, 2022 at 12:42 AM Christian König
> > wrote:
> >> Am 17.03.22 um 18:31 schrieb Rob Clark:
> >>> On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
> [SNIP]
> > (At so
On Fri, Mar 18, 2022 at 08:12:54AM -0700, Rob Clark wrote:
> On Fri, Mar 18, 2022 at 12:42 AM Christian König
> wrote:
> >
> > Am 17.03.22 um 18:31 schrieb Rob Clark:
> > > On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
> > >> [SNIP]
> > >>> (At some point, I'd like to use scheduler for th
Am 18.03.22 um 16:12 schrieb Rob Clark:
On Fri, Mar 18, 2022 at 12:42 AM Christian König
wrote:
Am 17.03.22 um 18:31 schrieb Rob Clark:
On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
[SNIP]
(At some point, I'd like to use scheduler for the replay, and actually
use drm_sched_stop()/et
On Fri, Mar 18, 2022 at 12:42 AM Christian König
wrote:
>
> Am 17.03.22 um 18:31 schrieb Rob Clark:
> > On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
> >> [SNIP]
> >>> (At some point, I'd like to use scheduler for the replay, and actually
> >>> use drm_sched_stop()/etc.. but last time I l
Am 17.03.22 um 18:31 schrieb Rob Clark:
On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
[SNIP]
(At some point, I'd like to use scheduler for the replay, and actually
use drm_sched_stop()/etc.. but last time I looked there were still
some sched bugs in that area which prevented me from de
On Thu, Mar 17, 2022 at 10:27 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote:
> > On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> > >
> > > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > > Am 16.03.22 um 16:36 schrieb Rob Clark
On Thu, Mar 17, 2022 at 08:40:51AM -0700, Rob Clark wrote:
> On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> >
> > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > > [SNIP]
> > > > just one point of clarification.. in the m
On Thu, Mar 17, 2022 at 08:34:21AM -0700, Rob Clark wrote:
> On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
> >
> > On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > > [SNIP]
> > > > just one point of clarification.. in the m
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > [SNIP]
> > > just one point of clarification.. in the msm and i915 case it is
> > > purely for debugging and telemetry (ie. se
On Thu, Mar 17, 2022 at 2:29 AM Daniel Vetter wrote:
>
> On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> > Am 16.03.22 um 16:36 schrieb Rob Clark:
> > > [SNIP]
> > > just one point of clarification.. in the msm and i915 case it is
> > > purely for debugging and telemetry (ie. se
Hi,
On Thu, 17 Mar 2022 at 09:21, Christian König wrote:
> Am 17.03.22 um 09:42 schrieb Sharma, Shashank:
> >> AFAIU you probably want to be passing around a `struct pid *`, and
> >> then somehow use pid_vnr() in the context of the process reading the
> >> event to get the numeric pid. Otherwise
Am 17.03.22 um 10:29 schrieb Daniel Vetter:
On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
Am 16.03.22 um 16:36 schrieb Rob Clark:
[SNIP]
just one point of clarification.. in the msm and i915 case it is
purely for debugging and telemetry (ie. sending crash logs back to
distro
On Thu, Mar 17, 2022 at 08:03:27AM +0100, Christian König wrote:
> Am 16.03.22 um 16:36 schrieb Rob Clark:
> > [SNIP]
> > just one point of clarification.. in the msm and i915 case it is
> > purely for debugging and telemetry (ie. sending crash logs back to
> > distro for analysis if user has crash
On Mon, Mar 14, 2022 at 10:23:27AM -0400, Alex Deucher wrote:
> On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> >
> > On Thu, 10 Mar 2022 11:56:41 -0800
> > Rob Clark wrote:
> >
> > > For something like just notifying a compositor that a gpu crash
> > > happened, perhaps drm_event is more
Am 17.03.22 um 09:42 schrieb Sharma, Shashank:
On 3/16/2022 10:50 PM, Rob Clark wrote:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information li
On 3/16/2022 10:50 PM, Rob Clark wrote:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information like:
- process ID of the process involved with
Am 16.03.22 um 16:36 schrieb Rob Clark:
[SNIP]
just one point of clarification.. in the msm and i915 case it is
purely for debugging and telemetry (ie. sending crash logs back to
distro for analysis if user has crash reporting enabled).. it isn't
used for triggering any action like killing app or
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch adds a new sysfs event, which will indicate
> the userland about a GPU reset, and can also provide
> some information like:
> - process ID of the process involved with the GPU reset
> - process name of
On Wed, Mar 16, 2022 at 8:48 AM Alex Deucher wrote:
>
> On Wed, Mar 16, 2022 at 11:35 AM Rob Clark wrote:
> >
> > On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote:
> > >
> > > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen
> > > wrote:
> > > >
> > [snip]
> > > > With new UAPI comes the deman
On Wed, Mar 16, 2022 at 11:35 AM Rob Clark wrote:
>
> On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote:
> >
> > On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote:
> > >
> [snip]
> > > With new UAPI comes the demand of userspace proof, not hand-waving. You
> > > would not be proposing this n
On Wed, Mar 16, 2022 at 7:12 AM Alex Deucher wrote:
>
> On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote:
> >
[snip]
> > With new UAPI comes the demand of userspace proof, not hand-waving. You
> > would not be proposing this new interface if you didn't have use cases
> > in mind, even just on
On Wed, Mar 16, 2022 at 4:48 AM Pekka Paalanen wrote:
>
> On Tue, 15 Mar 2022 10:54:38 -0400
> Alex Deucher wrote:
>
> > On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote:
> > >
> > > On Mon, 14 Mar 2022 10:23:27 -0400
> > > Alex Deucher wrote:
> > >
> > > > On Fri, Mar 11, 2022 at 3:30 AM
On Tue, 15 Mar 2022 10:54:38 -0400
Alex Deucher wrote:
> On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote:
> >
> > On Mon, 14 Mar 2022 10:23:27 -0400
> > Alex Deucher wrote:
> >
> > > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen
> > > wrote:
> > > >
> > > > On Thu, 10 Mar 2022 11:5
On Mon, Mar 14, 2022 at 11:26 AM Pekka Paalanen wrote:
>
> On Mon, 14 Mar 2022 10:23:27 -0400
> Alex Deucher wrote:
>
> > On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> > >
> > > On Thu, 10 Mar 2022 11:56:41 -0800
> > > Rob Clark wrote:
> > >
> > > > For something like just notifying a
Am 15.03.22 um 08:13 schrieb Dave Airlie:
On Tue, 15 Mar 2022 at 00:23, Alex Deucher wrote:
On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
On Thu, 10 Mar 2022 11:56:41 -0800
Rob Clark wrote:
For something like just notifying a compositor that a gpu crash
happened, perhaps drm_event
On Tuesday, March 15th, 2022 at 08:13, Dave Airlie wrote:
> Just one thing comes to mind reading this, racy PID reuse.
>
> process 1234 does something bad to GPU.
> process 1234 dies in parallel to sysfs notification being sent.
> other process 1234 reuses the pid
> new process 1234 gets destroye
On Tue, 15 Mar 2022 at 00:23, Alex Deucher wrote:
>
> On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> >
> > On Thu, 10 Mar 2022 11:56:41 -0800
> > Rob Clark wrote:
> >
> > > For something like just notifying a compositor that a gpu crash
> > > happened, perhaps drm_event is more suitable
On Mon, 14 Mar 2022 10:23:27 -0400
Alex Deucher wrote:
> On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
> >
> > On Thu, 10 Mar 2022 11:56:41 -0800
> > Rob Clark wrote:
> >
> > > For something like just notifying a compositor that a gpu crash
> > > happened, perhaps drm_event is more su
On Fri, Mar 11, 2022 at 3:30 AM Pekka Paalanen wrote:
>
> On Thu, 10 Mar 2022 11:56:41 -0800
> Rob Clark wrote:
>
> > For something like just notifying a compositor that a gpu crash
> > happened, perhaps drm_event is more suitable. See
> > virtio_gpu_fence_event_create() for an example of adding
On Thu, 10 Mar 2022 11:56:41 -0800
Rob Clark wrote:
> For something like just notifying a compositor that a gpu crash
> happened, perhaps drm_event is more suitable. See
> virtio_gpu_fence_event_create() for an example of adding new event
> types. Although maybe you want it to be an event which
On 3/10/2022 8:56 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 11:44 AM Sharma, Shashank
wrote:
On 3/10/2022 8:35 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank
wrote:
On 3/10/2022 7:33 PM, Abhinav Kumar wrote:
On 3/10/2022 9:40 AM, Rob Clark wrote:
On Th
On Thu, Mar 10, 2022 at 11:44 AM Sharma, Shashank
wrote:
>
>
>
> On 3/10/2022 8:35 PM, Rob Clark wrote:
> > On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank
> > wrote:
> >>
> >>
> >>
> >> On 3/10/2022 7:33 PM, Abhinav Kumar wrote:
> >>>
> >>>
> >>> On 3/10/2022 9:40 AM, Rob Clark wrote:
> O
On 3/10/2022 8:35 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank
wrote:
On 3/10/2022 7:33 PM, Abhinav Kumar wrote:
On 3/10/2022 9:40 AM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank
wrote:
On 3/10/2022 6:10 PM, Rob Clark wrote:
On Thu
On Thu, Mar 10, 2022 at 11:14 AM Sharma, Shashank
wrote:
>
>
>
> On 3/10/2022 7:33 PM, Abhinav Kumar wrote:
> >
> >
> > On 3/10/2022 9:40 AM, Rob Clark wrote:
> >> On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank
> >> wrote:
> >>>
> >>>
> >>>
> >>> On 3/10/2022 6:10 PM, Rob Clark wrote:
> On
On 3/10/2022 7:33 PM, Abhinav Kumar wrote:
On 3/10/2022 9:40 AM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank
wrote:
On 3/10/2022 6:10 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank
wrote:
On 3/10/2022 4:24 PM, Rob Clark wrote:
On Thu,
On 3/10/2022 9:40 AM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank
wrote:
On 3/10/2022 6:10 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank
wrote:
On 3/10/2022 4:24 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 1:55 AM Christian König
wrot
On Thu, Mar 10, 2022 at 9:19 AM Sharma, Shashank
wrote:
>
>
>
> On 3/10/2022 6:10 PM, Rob Clark wrote:
> > On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank
> > wrote:
> >>
> >>
> >>
> >> On 3/10/2022 4:24 PM, Rob Clark wrote:
> >>> On Thu, Mar 10, 2022 at 1:55 AM Christian König
> >>> wrote:
> >
On 3/10/2022 6:10 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank
wrote:
On 3/10/2022 4:24 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 1:55 AM Christian König
wrote:
Am 09.03.22 um 19:12 schrieb Rob Clark:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrot
On Thu, Mar 10, 2022 at 8:27 AM Andrey Grodzovsky
wrote:
>
>
> On 2022-03-10 11:21, Sharma, Shashank wrote:
> >
> >
> > On 3/10/2022 4:24 PM, Rob Clark wrote:
> >> On Thu, Mar 10, 2022 at 1:55 AM Christian König
> >> wrote:
> >>>
> >>>
> >>>
> >>> Am 09.03.22 um 19:12 schrieb Rob Clark:
> On
On Thu, Mar 10, 2022 at 8:21 AM Sharma, Shashank
wrote:
>
>
>
> On 3/10/2022 4:24 PM, Rob Clark wrote:
> > On Thu, Mar 10, 2022 at 1:55 AM Christian König
> > wrote:
> >>
> >>
> >>
> >> Am 09.03.22 um 19:12 schrieb Rob Clark:
> >>> On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
> >>> wrote:
> >
On 2022-03-10 11:21, Sharma, Shashank wrote:
On 3/10/2022 4:24 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 1:55 AM Christian König
wrote:
Am 09.03.22 um 19:12 schrieb Rob Clark:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysf
On 3/10/2022 4:24 PM, Rob Clark wrote:
On Thu, Mar 10, 2022 at 1:55 AM Christian König
wrote:
Am 09.03.22 um 19:12 schrieb Rob Clark:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about
On Thu, Mar 10, 2022 at 1:55 AM Christian König
wrote:
>
>
>
> Am 09.03.22 um 19:12 schrieb Rob Clark:
> > On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
> > wrote:
> >> From: Shashank Sharma
> >>
> >> This patch adds a new sysfs event, which will indicate
> >> the userland about a GPU reset, a
Am 09.03.22 um 19:12 schrieb Rob Clark:
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information like:
- process ID of the process involved with
On Tue, Mar 8, 2022 at 11:40 PM Shashank Sharma
wrote:
>
> From: Shashank Sharma
>
> This patch adds a new sysfs event, which will indicate
> the userland about a GPU reset, and can also provide
> some information like:
> - process ID of the process involved with the GPU reset
> - process name of
On 3/9/2022 8:47 AM, Simon Ser wrote:
Hi,
Maybe it would be a good idea to state the intended use-case in the
commit message?
It was added in the second patch, but yeah, it makes more sense to add a
cover-letter probably.
And explain why the current (driver-specific IIRC) APIs
aren't e
On 09/03/2022 11:24, Christian König wrote:
> Am 09.03.22 um 11:10 schrieb Simon Ser:
>> On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer
>> wrote:
>>
>>> Would it be possible to include the app parameters as well?
>> Can all processes read sysfs events?
>
> No, but applicat
On Wednesday, March 9th, 2022 at 11:24, Christian König
wrote:
> Am 09.03.22 um 11:10 schrieb Simon Ser:
> > On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer
> > wrote:
> >
> >> Would it be possible to include the app parameters as well?
> > Can all processes read sysfs event
Am 09.03.22 um 11:10 schrieb Simon Ser:
On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer
wrote:
Would it be possible to include the app parameters as well?
Can all processes read sysfs events?
No, but application parameters are usually not secret.
There might be securit
On Wednesday, March 9th, 2022 at 10:56, Pierre-Eric Pelloux-Prayer
wrote:
> Would it be possible to include the app parameters as well?
Can all processes read sysfs events?
There might be security implications here. The app parameters might
contain sensitive information, like passwords or toke
Hi Shashank,
On 08/03/2022 19:04, Shashank Sharma wrote:
> From: Shashank Sharma
>
> This patch adds a new sysfs event, which will indicate
> the userland about a GPU reset, and can also provide
> some information like:
> - process ID of the process involved with the GPU reset
> - process name o
Am 08.03.22 um 19:04 schrieb Shashank Sharma:
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information like:
- process ID of the process involved with the GPU reset
- process name of the involved process
-
Hi,
Maybe it would be a good idea to state the intended use-case in the
commit message? And explain why the current (driver-specific IIRC) APIs
aren't enough?
Since this introduces new uAPI, can you point to a user-space patch
which uses the new uAPI? See this link for more info on DRM user-space
From: Shashank Sharma
This patch adds a new sysfs event, which will indicate
the userland about a GPU reset, and can also provide
some information like:
- process ID of the process involved with the GPU reset
- process name of the involved process
- the GPU status info (using flags)
This patch a
62 matches
Mail list logo
