Re: [PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-11-01 Thread Mario Limonciello
On 10/31/2024 15:50, Antonio Quartulli wrote: On 31/10/2024 20:37, Mario Limonciello wrote: On 10/31/2024 10:28, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Although this case may

Re: [PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-11-01 Thread Antonio Quartulli
On 31/10/2024 20:37, Mario Limonciello wrote: On 10/31/2024 10:28, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Although this case may be unrealistic for the current code, it is stil

[PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Antonio Quartulli
acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Although this case may be unrealistic for the current code, it is still better to protect against possible bugs. Bail out also when status is AE_NOT_FOUND. This fi

Re: [PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Mario Limonciello
On 10/31/2024 10:28, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Although this case may be unrealistic for the current code, it is still better to protect against possible bugs. Bai

Re: [PATCH v2] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-31 Thread Markus Elfring
… > Although this case may be unrealistic for the current code, it is > still better to protect against possible bugs. > > Bail out also when status is AE_NOT_FOUND. … How do you think about to add any tags (like “Fixes” and “Cc”) accordingly? https://git.kernel.org/pub/scm/linux/kernel/git/torval