Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2025-04-28 Thread Alex Deucher
On Sun, Apr 27, 2025 at 5:46 AM R Sundar wrote: > > Use string choice helpers for better readability. > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/ > Signed-off-by: R Sundar > --- > > Reported in linux rep

[PATCH linux-next] drm/amdgpu: use string choice helpers

2025-04-27 Thread R Sundar
Use string choice helpers for better readability. Reported-by: kernel test robot Reported-by: Julia Lawall Closes: https://lore.kernel.org/r/202503222049.suxl3q6w-...@intel.com/ Signed-off-by: R Sundar --- Reported in linux repository. cocci warnings: (new ones prefixed by >>) >> drivers/gpu/

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-30 Thread R Sundar
On 29/10/24 19:11, Alex Deucher wrote: On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: Use string choice helpers for better readability. I personally find this less readable, but if this is the preferred method going forward, I'm fine to take the patch. Alex Hi, Thanks for the comments

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 1:05 PM R Sundar wrote: > > On 29/10/24 19:11, Alex Deucher wrote: > > On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > >> > >> Use string choice helpers for better readability. > > > > I personally find this less readable, but if this is the preferred > > method going f

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > > Use string choice helpers for better readability. I personally find this less readable, but if this is the preferred method going forward, I'm fine to take the patch. Alex > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Clo

[PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-28 Thread R Sundar
Use string choice helpers for better readability. Reported-by: kernel test robot Reported-by: Julia Lawall Closes: https://lore.kernel.org/r/202410161814.i6p2nnux-...@intel.com/ Signed-off-by: R Sundar --- reported in linux repository. tree: https://git.kernel.org/pub/scm/linux/kernel/git/to