Re: [PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-04-10 Thread Simon Ser
On Tuesday, April 1st, 2025 at 04:42, Alex Hung wrote: > On 3/29/25 09:48, Simon Ser wrote: > > > I would prefer these functions to be introduced together with the > > patches adding functions to create objects and adding the new fields. > > That way it's easier to check the symmetry and at no p

Re: [PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-04-05 Thread Alex Hung
On 3/29/25 09:48, Simon Ser wrote: I would prefer these functions to be introduced together with the patches adding functions to create objects and adding the new fields. That way it's easier to check the symmetry and at no point in the series there are memory leaks. The object creation and

Re: [PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-03-29 Thread Simon Ser
I would prefer these functions to be introduced together with the patches adding functions to create objects and adding the new fields. That way it's easier to check the symmetry and at no point in the series there are memory leaks. Additionally, I would avoid using the name "cleanup", which seems

[PATCH V8 43/43] drm/colorop: Add destroy functions for color pipeline

2025-03-26 Thread Alex Hung
The functions are to clean up color pipeline when a device driver fails to create its color pipeline. Signed-off-by: Alex Hung --- .../amd/display/amdgpu_dm/amdgpu_dm_colorop.c | 3 +- drivers/gpu/drm/drm_colorop.c | 41 +++ drivers/gpu/drm/vkms/vkms_colorop.c