Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-06 Thread Ville Syrjälä
On Thu, Sep 05, 2019 at 07:51:59PM +, Siqueira, Rodrigo wrote: > Hi Ville, > > First of all, thank you very much for the review. > > I added some comments below. > > On 09/05, Wentland, Harry wrote: > > On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > > > On Wed, Sep 04, 2019 at 07:02:18PM +0

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Siqueira, Rodrigo
Hi Ville, First of all, thank you very much for the review. I added some comments below. On 09/05, Wentland, Harry wrote: > On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > > On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: > >> DP 1.4a specification defines Link Training Tunabl

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Harry Wentland
On 2019-09-05 1:29 p.m., Ville Syrjälä wrote: > On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: >> DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) > > A bunch of this stuff was already in DP 1.3 so the statement here > (and in the comment) is a bit misle

Re: [PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-05 Thread Ville Syrjälä
On Wed, Sep 04, 2019 at 07:02:18PM +, Siqueira, Rodrigo wrote: > DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) A bunch of this stuff was already in DP 1.3 so the statement here (and in the comment) is a bit misleading. "LTTPR" is not a name that appears anywhere in

[PATCH V4] drm: Add LTTPR defines for DP 1.4a

2019-09-04 Thread Siqueira, Rodrigo
DP 1.4a specification defines Link Training Tunable PHY Repeater (LTTPR) which is required to add support for systems with Thunderbolt or other repeater devices. Changes since V3: - Replace spaces by tabs Changes since V2: - Drop the kernel-doc comment - Reorder LTTPR according to register offset