Re: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions

2020-02-25 Thread Zhao, Yong
: Kuehling, Felix Sent: Tuesday, February 25, 2020 12:06 PM To: Zhao, Yong ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions As I understand it, the SDMA queue counting wasn't incorrect. The main change here is that you no l

Re: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions

2020-02-25 Thread Felix Kuehling
As I understand it, the SDMA queue counting wasn't incorrect. The main change here is that you no longer send separate unmap packets for SDMA queues, and that makes SDMA queue counting unnecessary. That said, this patch series is a nice cleanup and improvement. The series is Reviewed-by: Fel

Re: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions

2020-02-25 Thread Deucher, Alexander
[AMD Public Use] Series is: Acked-by: Alex Deucher From: amd-gfx on behalf of Yong Zhao Sent: Monday, February 24, 2020 5:18 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Yong Subject: [PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package

[PATCH 6/6] drm/amdkfd: Delete unnecessary unmap queue package submissions

2020-02-24 Thread Yong Zhao
The previous SDMA queue counting was wrong. In addition, after confirming with MEC firmware team, we understands that only one unmap queue package, instead of one unmap queue package for CP and each SDMA engine, is needed, which results in much simpler driver code. Change-Id: I84fd2f7e63d6b7f66458