RE: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-16 Thread Russell, Kent
g > Cc: Deucher, Alexander ; Bhardwaj, Rajneesh > > Subject: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume > > SDMA 5.x is part of the GFX block so it's controlled via > GFXOFF. Skip suspend as it should be handled the same > as GFX. > > v2:

[PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Alex Deucher
SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x. That requires special handling. Acked-by: Rajneesh Bhardwaj Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file

Re: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Alex Deucher
On Thu, Dec 15, 2022 at 10:05 AM Bhardwaj, Rajneesh wrote: > > Don't we need a similar check on resume_phase2? The resume code looks to see if the IP was suspended in the first place before trying to resume it so no need. Alex > > Other than that, looks good to me. > > Acked-by: Rajneesh Bhardw

Re: [PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-15 Thread Bhardwaj, Rajneesh
Don't we need a similar check on resume_phase2? Other than that, looks good to me. Acked-by: Rajneesh Bhardwaj On 12/14/2022 5:16 PM, Alex Deucher wrote: SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x.

[PATCH 5/7] drm/amdgpu: for S0ix, skip SMDA 5.x+ suspend/resume

2022-12-14 Thread Alex Deucher
SDMA 5.x is part of the GFX block so it's controlled via GFXOFF. Skip suspend as it should be handled the same as GFX. v2: drop SDMA 4.x. That requires special handling. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++ 1 file changed, 6 insertions(+) dif