: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
In this case feel free to add an Acked-by: Christian König
to your patch.
But I would recommend to get an rb from somebody which knows that stuff better
than I do.
Regards,
Christian.
Am
: Liu, Monk ; Yuan, Xiaojie ; Deucher, Alexander
; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
Hi Monk,
if the content of the CSIB is constant then it is certainly better to just
re-initialize it.
This also prevents from
: Christian König
Sent: Thursday, November 28, 2019 7:51 PM
To: Liu, Monk ; Yuan, Xiaojie ;
Deucher, Alexander ; Koenig, Christian
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
Hi Monk,
if the content of the CSIB is constant then it is
ember 26, 2019 9:10 PM
To: Liu, Monk
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
Hi Monk,
hw_fini() is called in suspend code path as well. I'm wondering how csb can be
evicted if it's not unpined before suspend.
BR,
Xiaojie
org
Subject: RE: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
Hi Xiaojie
For SRIOV we don't use suspend so I didn't think to that part, thanks for the
remind !
But we still need to fix this call trace issue anyway (our jenkins testing
system consider such call trace as an
on Team |AMD
-Original Message-
From: Yuan, Xiaojie
Sent: Tuesday, November 26, 2019 9:10 PM
To: Liu, Monk
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
Hi Monk,
hw_fini() is called in suspend code path as well. I'm wond
ping
_
Monk Liu|GPU Virtualization Team |AMD
-Original Message-
From: Monk Liu
Sent: Tuesday, November 26, 2019 7:50 PM
To: amd-gfx@lists.freedesktop.org
Cc: Liu, Monk
Subject: [PATCH 5/5] drm/amdgpu: fix calltrace during kmd unload
kernel would
Hi Monk,
hw_fini() is called in suspend code path as well. I'm wondering how csb can be
evicted if it's not unpined before suspend.
BR,
Xiaojie
> On Nov 26, 2019, at 7:50 PM, Monk Liu wrote:
>
> kernel would report a warning on double unpin
> on the csb BO because we unpin it during hw_fini
>
kernel would report a warning on double unpin
on the csb BO because we unpin it during hw_fini
but actually we don't need to pin/unpin it during
hw_init/fini since it is created with kernel pinned
remove all those useless code for gfx9/10
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/a
