Re: [PATCH 2/6] drm/amdgpu/vcn2.5: add direct SRAM read and write

Sure. Thanks! James On 2020-01-14 2:06 p.m., Leo Liu wrote: I think you can avoid the duplication, instead adding instance to "RREG32(WREG)_SOC15_DPG_MODE_2_0(offset, mask_en) ", just like adding instance to other part of the code. Regards, Leo On 2020-01-14 12:58 p.m., James Zhu wrote:

Re: [PATCH 2/6] drm/amdgpu/vcn2.5: add direct SRAM read and write

I think you can avoid the duplication, instead adding instance to "RREG32(WREG)_SOC15_DPG_MODE_2_0(offset, mask_en) ", just like adding instance to other part of the code. Regards, Leo On 2020-01-14 12:58 p.m., James Zhu wrote: Add direct SRAM read and write MACRO for vcn2.5 Signed-off-by:

[PATCH 2/6] drm/amdgpu/vcn2.5: add direct SRAM read and write

Add direct SRAM read and write MACRO for vcn2.5 Signed-off-by: James Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h index 26c6623..d3d75ec 1