Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom

2020-03-17 Thread Christoph Hellwig
Any reason drivers can't just use pci_map_rom insteadá¼… which already does the right thing? ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom

2020-03-03 Thread Mikel Rychliski
On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote: > Cosmetics: > > s/ioremap/ioremap()/ (also in commit log) > s/phys_to_virt/phys_to_virt()/ (also in commit log) > s/pci_platform_rom/pci_platform_rom()/ (commit log) > s/rom/ROM/ > This changes the interface of pci_platform_rom() (the

Re: [PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom

2020-03-03 Thread Bjorn Helgaas
Cosmetics: s/ioremap/ioremap()/ (also in commit log) s/phys_to_virt/phys_to_virt()/ (also in commit log) s/pci_platform_rom/pci_platform_rom()/ (commit log) s/rom/ROM/ On Mon, Mar 02, 2020 at 10:34:55PM -0500, Mikel Rychliski wrote: > On some EFI systems, the video BIOS is provided by the EFI fir

[PATCH 2/4] PCI: Use ioremap, not phys_to_virt for platform rom

2020-03-03 Thread Mikel Rychliski
On some EFI systems, the video BIOS is provided by the EFI firmware. The boot stub code stores the physical address of the ROM image in pdev->rom. Currently we attempt to access this pointer using phys_to_virt, which doesn't work with CONFIG_HIGHMEM. On these systems, attempting to load the radeo