Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Kuehling, Felix
aybe doing a v11 if GFX11 changes things, and only GFX11 ASICs >> use those functions/variables. >> >> >> >> Obviously not high-priority, but maybe something to consider as you continue >> to consolidate and remove duplicate code. >> >> >> &g

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Zhao, Yong
g <mailto:yong.z...@amd.com>; Alex Deucher <mailto:alexdeuc...@gmail.com> Cc: Russell, Kent <mailto:kent.russ...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/3] drm/amdkfd: onl

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Kuehling, Felix
:12 PM To: Zhao, Yong <mailto:yong.z...@amd.com>; Alex Deucher <mailto:alexdeuc...@gmail.com> Cc: Russell, Kent <mailto:kent.russ...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/3]

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Zhao, Yong
, it is a must. Regards, Yong From: Kuehling, Felix Sent: Thursday, November 7, 2019 2:12 PM To: Zhao, Yong ; Alex Deucher Cc: Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii On 2019-11

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Kuehling, Felix
consider as you continue > to consolidate and remove duplicate code. > > > > Kent > > > > From: amd-gfx > <mailto:amd-gfx-boun...@lists.freedesktop.org> > On Behalf Of Zhao, Yong > Sent: Thursday, November 7, 2019 11:57 AM > To: Kuehling, Felix <mailto:f

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Zhao, Yong
; Russell, Kent ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii On Thu, Nov 7, 2019 at 12:47 PM Kuehling, Felix wrote: > > No, please lets not add a new nomenclature for PM4 packet versions. GFX > versions are agreed on between

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Alex Deucher
GFX11 ASICs use those > functions/variables. > > > > Obviously not high-priority, but maybe something to consider as you continue > to consolidate and remove duplicate code. > > > > Kent > > > > From: amd-gfx On Behalf Of Zhao, Yong > Sent: Thursday, November 7,

RE: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Russell, Kent
: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii No, please lets not add a new nomenclature for PM4 packet versions. GFX versions are agreed on between hardware, firmware, and software and it's generally understood what they mean. If we add a new PM4 packet versioning scheme o

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Kuehling, Felix
<mailto:amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Zhao, Yong Sent: Thursday, November 7, 2019 11:57 AM To: Kuehling, Felix <mailto:felix.kuehl...@amd.com>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 2/3] drm/amdkfd: only ke

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Zhao, Yong
dnesday, November 6, 2019 11:45 PM To: Zhao, Yong mailto:yong.z...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii On 2019-10-30

RE: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Russell, Kent
November 6, 2019 11:45 PM To: Zhao, Yong mailto:yong.z...@amd.com>>; amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> mailto:amd-gfx@lists.freedesktop.org>> Subject: Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii On 2019-10-30 20:17, Zhao, Yong wrot

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-07 Thread Zhao, Yong
t: Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii On 2019-10-30 20:17, Zhao, Yong wrote: > release_mem won't be used at all on GFX9 and GFX10, so delete it. Hawaii was GFXv7. So we're not using the release_mem packet on GFXv8 either. Why arbitrarily limit this c

Re: [PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-11-06 Thread Kuehling, Felix
On 2019-10-30 20:17, Zhao, Yong wrote: > release_mem won't be used at all on GFX9 and GFX10, so delete it. Hawaii was GFXv7. So we're not using the release_mem packet on GFXv8 either. Why arbitrarily limit this change to GFXv9 and 10? Regards,   Felix > > Change-Id: I13787a8a29b83e7516c582a740

[PATCH 2/3] drm/amdkfd: only keep release_mem function for Hawaii

2019-10-30 Thread Zhao, Yong
release_mem won't be used at all on GFX9 and GFX10, so delete it. Change-Id: I13787a8a29b83e7516c582a7401f2e14721edf5f Signed-off-by: Yong Zhao --- .../gpu/drm/amd/amdkfd/kfd_kernel_queue_v10.c | 35 ++- .../gpu/drm/amd/amdkfd/kfd_kernel_queue_v9.c | 33 ++--- 2 file