Re: [PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-13 Thread Christian König
Am 13.09.2018 um 00:58 schrieb Felix Kuehling: Is the small reduction in memory footprint (8 bytes per page table on a 64-bit kernel) really worth the trouble of open-coding a single-linked list implementation? Well the key point is it is now a power of two again. So we don't waste 28KB per pa

Re: [PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-12 Thread Felix Kuehling
Is the small reduction in memory footprint (8 bytes per page table on a 64-bit kernel) really worth the trouble of open-coding a single-linked list implementation? I guess this change makes a bigger difference for 2-level page tables than it does for 4-level, because the amdgpu_vm_pt array is alloc

Re: [PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-12 Thread zhoucm1
Reviewed-by: Chunming Zhou On 2018年09月12日 16:55, Christian König wrote: Instead of the double linked list. Gets the size of amdgpu_vm_pt down to 64 bytes again. We could even reduce it down to 32 bytes, but that would require some rather extreme hacks. Signed-off-by: Christian König --- d

[PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-12 Thread Christian König
Instead of the double linked list. Gets the size of amdgpu_vm_pt down to 64 bytes again. We could even reduce it down to 32 bytes, but that would require some rather extreme hacks. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/