Re: [PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-02 Thread Marek Olšák
On Fri, Sep 2, 2016 at 12:56 PM, Christian König wrote: > Am 02.09.2016 um 12:33 schrieb Marek Olšák: >> >> On Fri, Sep 2, 2016 at 9:38 AM, Christian König >> wrote: >>> >>> Am 01.09.2016 um 16:33 schrieb Deucher, Alexander: >>> return r; > + > + return -ENOMEM; > +} >>> >>> Unreachable code

Re: [PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-02 Thread Christian König
Am 02.09.2016 um 12:33 schrieb Marek Olšák: On Fri, Sep 2, 2016 at 9:38 AM, Christian König wrote: Am 01.09.2016 um 16:33 schrieb Deucher, Alexander: return r; > + > + return -ENOMEM; > +} Unreachable code. Other than that looks good. Ups, indeed just a merge error. With that fixed: Revie

Re: [PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-02 Thread Marek Olšák
On Fri, Sep 2, 2016 at 9:38 AM, Christian König wrote: > Am 01.09.2016 um 16:33 schrieb Deucher, Alexander: > >> return r; > + > + return -ENOMEM; > +} > > Unreachable code. Other than that looks good. > > > Ups, indeed just a merge error. > > With that fixed: Reviewed-by: Alex Deucher > > Thanks

Re: [PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-02 Thread Christian König
Am 01.09.2016 um 16:33 schrieb Deucher, Alexander: >return r; > + > + return -ENOMEM; > +} Unreachable code. Other than that looks good. Ups, indeed just a merge error. With that fixed: Reviewed-by: Alex Deucher Thanks for the review, I've just pushed the resulting patches to amd-staging-4

RE: [PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-01 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Thursday, September 01, 2016 10:16 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 2/2] drm/amdgpu: prevent command submission failu

[PATCH 2/2] drm/amdgpu: prevent command submission failures under memory pressure

2016-09-01 Thread Christian König
From: Christian König As last resort try to evict BOs from the current working set into other memory domains. This effectively prevents command submission failures when VM page tables have been swapped out. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drive