On 2019-09-04 8:17 a.m., Christian König wrote:
> Move the ASIC specific code into a new callback function.
>
> v2: mask the flags for SI and CIK instead of a BUG_ON().
>
> Signed-off-by: Christian König
Nit-pick inline. Otherwise the series is
Reviewed-by: Felix Kuehling
> ---
> drivers/gp
Series look good for me.
Reviewed-by: Huang Rui
-Original Message-
From: amd-gfx On Behalf Of Christian
König
Sent: Wednesday, September 4, 2019 8:17 AM
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 2/2] drm/amdgpu: cleanup PTE flag generation v2
Move the ASIC specific code into
Move the ASIC specific code into a new callback function.
v2: mask the flags for SI and CIK instead of a BUG_ON().
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29 ++---
drivers/gpu/drm/amd/a
the mapping structure still keep the UAPI flag and all the HW specific PTE
setting is in the
last step before real set to HW ?
I thought about that approach as well, but that would unfortunately not
work correctly.
The problem is that we have some mapping flags which don't have an
users
Am 03.09.19 um 22:28 schrieb Kuehling, Felix:
On 2019-09-02 10:57 a.m., Christian König wrote:
Move the ASIC specific code into a new callback function.
NAK. I believe the BUG_ONs you're adding will trigger with ROCm on
Hawaii and Kaveri. See inline ...
Those are the flags as generated by the
Maybe it's not necessary to separate the mtype from the get_vm_pte
function , so we just need one asic specific functions (get_vm_pte) .
What make me confusing originally is the the logic to setup the PTE
flag. We first map the UAPI flags to HW specific PTE flag , save it
into mapping
On 2019-09-02 10:57 a.m., Christian König wrote:
> Move the ASIC specific code into a new callback function.
NAK. I believe the BUG_ONs you're adding will trigger with ROCm on
Hawaii and Kaveri. See inline ...
ROCm user mode doesn't care that the page table doesn't have an
executable bit on tho
Move the ASIC specific code into a new callback function.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.h | 5 +
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 29 ++---
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 22 ++-
drivers/gpu/d
