Re: [PATCH 2/2] drm/amd/dc: Kill dc_conn_log_hex_linux()

2020-04-01 Thread Alex Deucher
On Wed, Apr 1, 2020 at 9:00 AM Kazlauskas, Nicholas wrote: > > On 2020-03-31 5:22 p.m., Lyude Paul wrote: > > DRM already supports tracing DPCD transactions, there's no reason for > > the existence of this function. Also, it prints one byte per-line which > > is way too loud. So, just remove it. >

Re: [PATCH 2/2] drm/amd/dc: Kill dc_conn_log_hex_linux()

2020-04-01 Thread Kazlauskas, Nicholas
On 2020-03-31 5:22 p.m., Lyude Paul wrote: DRM already supports tracing DPCD transactions, there's no reason for the existence of this function. Also, it prints one byte per-line which is way too loud. So, just remove it. Signed-off-by: Lyude Paul Thanks for helping clean this up! Series is:

[PATCH 2/2] drm/amd/dc: Kill dc_conn_log_hex_linux()

2020-03-31 Thread Lyude Paul
DRM already supports tracing DPCD transactions, there's no reason for the existence of this function. Also, it prints one byte per-line which is way too loud. So, just remove it. Signed-off-by: Lyude Paul --- .../gpu/drm/amd/display/dc/basics/Makefile| 3 +- .../drm/amd/display/dc/basics/lo