Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-03-06 Thread Daniel Vetter
On Tue, Mar 06, 2018 at 10:30:56AM +0100, Christian König wrote: > Am 06.03.2018 um 10:15 schrieb Daniel Vetter: > > On Wed, Feb 28, 2018 at 11:25:59AM +0100, Christian König wrote: > > > Am 28.02.2018 um 10:48 schrieb Lucas Stach: > > > > Hi Christian, > > > > > > > > Am Dienstag, den 27.02.2018,

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-03-06 Thread Christian König
Am 06.03.2018 um 10:15 schrieb Daniel Vetter: On Wed, Feb 28, 2018 at 11:25:59AM +0100, Christian König wrote: Am 28.02.2018 um 10:48 schrieb Lucas Stach: Hi Christian, Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: Unpin the GEM object only after freeing the sg table. Wha

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-03-06 Thread Daniel Vetter
On Wed, Feb 28, 2018 at 11:25:59AM +0100, Christian König wrote: > Am 28.02.2018 um 10:48 schrieb Lucas Stach: > > Hi Christian, > > > > Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: > > > Unpin the GEM object only after freeing the sg table. > > What is the race that is being

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-03-05 Thread Christian König
Ping? Anybody who could give me an review on those changes? The first one is just nice to have, the rest is a nice memory usage reduction in some cases. Christian. Am 27.02.2018 um 12:49 schrieb Christian König: Unpin the GEM object only after freeing the sg table. Signed-off-by: Christian

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-28 Thread Christian König
Am 28.02.2018 um 10:48 schrieb Lucas Stach: Hi Christian, Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: Unpin the GEM object only after freeing the sg table. What is the race that is being fixed here? The SG table is private to the importer and the importer should hopefully

Re: [PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-28 Thread Lucas Stach
Hi Christian, Am Dienstag, den 27.02.2018, 12:49 +0100 schrieb Christian König: > Unpin the GEM object only after freeing the sg table. What is the race that is being fixed here? The SG table is private to the importer and the importer should hopefully only call map_detach if it is done with all

[PATCH 1/5] drm/prime: fix potential race in drm_gem_map_detach

2018-02-27 Thread Christian König
Unpin the GEM object only after freeing the sg table. Signed-off-by: Christian König --- drivers/gpu/drm/drm_prime.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c index e82a976f0fba