Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-30 Thread Alex Deucher
On Tue, Aug 30, 2016 at 1:33 PM, William Lewis wrote: > Question inline, probably my lack of understanding of the code. > > > On 08/29/16 04:20, Christian König wrote: >> From: Christian König >> >> Add a flag noting that a BO must be created using linear VRAM >> and set this flag on all in kerne

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-30 Thread William Lewis
Question inline, probably my lack of understanding of the code. On 08/29/16 04:20, Christian König wrote: > From: Christian König > > Add a flag noting that a BO must be created using linear VRAM > and set this flag on all in kernel users where appropriate. > > Hopefully I haven't missed anythin

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-30 Thread Christian König
Am 30.08.2016 um 03:49 schrieb Flora Cui: On Tue, Aug 30, 2016 at 09:57:56AM +0900, Michel Dänzer wrote: On 29/08/16 10:47 PM, Deucher, Alexander wrote: From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian König Sent: Monday, August 29, 2016 5:20 AM I still think

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-29 Thread Flora Cui
On Tue, Aug 30, 2016 at 09:57:56AM +0900, Michel Dänzer wrote: > On 29/08/16 10:47 PM, Deucher, Alexander wrote: > >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > >> Of Christian König > >> Sent: Monday, August 29, 2016 5:20 AM > > > > I still think this should be renam

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-29 Thread Michel Dänzer
On 29/08/16 10:47 PM, Deucher, Alexander wrote: >> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf >> Of Christian König >> Sent: Monday, August 29, 2016 5:20 AM > > I still think this should be renamed AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS > or the anti-flag AMDGPU_GEM_CREATE_V

RE: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-29 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian König > Sent: Monday, August 29, 2016 5:20 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/5] drm/amdgpu: add > AMDGPU_GEM_CREATE_VRAM_LINEAR flag v

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-29 Thread Edward O'Callaghan
On 08/29/2016 07:20 PM, Christian König wrote: > From: Christian König > > Add a flag noting that a BO must be created using linear VRAM > and set this flag on all in kernel users where appropriate. > > Hopefully I haven't missed anything. > > v2: add it in a few more places, fix CPU mapping.

[PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

2016-08-29 Thread Christian König
From: Christian König Add a flag noting that a BO must be created using linear VRAM and set this flag on all in kernel users where appropriate. Hopefully I haven't missed anything. v2: add it in a few more places, fix CPU mapping. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu