Re: [PATCH 1/3] amdgpu: move ttm domain definitions to amdgpu.h

2016-08-18 Thread Christian König
Am 18.08.2016 um 10:12 schrieb Flora Cui: On Thu, Aug 18, 2016 at 10:05:09AM +0200, Christian König wrote: NAK, we explicitly moved them to amdgpu_gds.h. In general when some code needs those defines it should include the appropriate header. But it would make sense to move them into a (to be c

Re: [PATCH 1/3] amdgpu: move ttm domain definitions to amdgpu.h

2016-08-18 Thread Flora Cui
On Thu, Aug 18, 2016 at 10:05:09AM +0200, Christian König wrote: > NAK, we explicitly moved them to amdgpu_gds.h. > > In general when some code needs those defines it should include the > appropriate header. > > But it would make sense to move them into a (to be created) amdgpu_ttm.h, > cause tho

Re: [PATCH 1/3] amdgpu: move ttm domain definitions to amdgpu.h

2016-08-18 Thread Christian König
NAK, we explicitly moved them to amdgpu_gds.h. In general when some code needs those defines it should include the appropriate header. But it would make sense to move them into a (to be created) amdgpu_ttm.h, cause those defines are more TTM related than GDS related. Regards, Christiuan. A

[PATCH 1/3] amdgpu: move ttm domain definitions to amdgpu.h

2016-08-17 Thread Flora Cui
Signed-off-by: Flora Cui --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_gds.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index a55eb6f..92064be